components/metrics/call_stack_profile_metrics_provider.h - Issue 2438073002: Use movable types for CallStackProfile(s) to remove copying of data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/call_stack_profile_metrics_provider.h

Issue 2438073002: Use movable types for CallStackProfile(s) to remove copying of data. (Closed)

Patch Set: fix tests and build problems Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/metrics/call_stack_profile_metrics_provider.h

diff --git a/components/metrics/call_stack_profile_metrics_provider.h b/components/metrics/call_stack_profile_metrics_provider.h

index d26000be087ba95a7242dd8c945431f2105b9229..ab13d46d126b6930d715e40143c2b8778eafac96 100644

--- a/components/metrics/call_stack_profile_metrics_provider.h

+++ b/components/metrics/call_stack_profile_metrics_provider.h

@@ -35,7 +35,7 @@ class CallStackProfileMetricsProvider : public MetricsProvider {

static void ReceiveCompletedProfiles(

const CallStackProfileParams& params,

base::TimeTicks start_timestamp,

- const base::StackSamplingProfiler::CallStackProfiles& profiles);

+ base::StackSamplingProfiler::CallStackProfiles profiles);

// MetricsProvider:

void OnRecordingEnabled() override;