Use movable types for CallStackProfile(s) to remove copying of data.

base/profiler/stack_sampling_profiler_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <cstdlib>
 
 #include "base/bind.h"
@@ skipping 291 matching lines @@
          ::GetLastError() != ERROR_MOD_NOT_FOUND) {
     PlatformThread::Sleep(TimeDelta::FromMilliseconds(1));
   }
 #else
   NOTIMPLEMENTED();
 #endif
 }
 
 // Called on the profiler thread when complete, to collect profiles.
 void SaveProfiles(CallStackProfiles* profiles,
-                  const CallStackProfiles& pending_profiles) {
-  *profiles = pending_profiles;
+                  CallStackProfiles pending_profiles) {
+  *profiles = std::move(pending_profiles);

[Mike Wittman, 2016/10/21 18:05:29]

IWYU: <utility>

... and throughout this CL

[bcwhite, 2016/10/24 13:17:45]

Done.

 }
 
 // Called on the profiler thread when complete. Collects profiles produced by
 // the profiler, and signals an event to allow the main thread to know that that
 // the profiler is done.
 void SaveProfilesAndSignalEvent(CallStackProfiles* profiles,
                                 WaitableEvent* event,
-                                const CallStackProfiles& pending_profiles) {
-  *profiles = pending_profiles;
+                                CallStackProfiles pending_profiles) {
+  *profiles = std::move(pending_profiles);
   event->Signal();
 }
 
 // Executes the function with the target thread running and executing within
 // SignalAndWaitUntilSignaled(). Performs all necessary target thread startup
 // and shutdown work before and afterward.
 template <class Function>
 void WithTargetThread(Function function,
                       const StackConfiguration& stack_config) {
   TargetThread target_thread(stack_config);
@@ skipping 643 matching lines @@
 #if defined(STACK_SAMPLING_PROFILER_SUPPORTED)
 #define MAYBE_UnloadedLibrary UnloadedLibrary
 #else
 #define MAYBE_UnloadedLibrary DISABLED_UnloadedLibrary
 #endif
 TEST(StackSamplingProfilerTest, MAYBE_UnloadedLibrary) {
   TestLibraryUnload(true);
 }
 
 }  // namespace base