Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2438063004: use_goma_module=True in chromium_libfuzzer_clang_tot (Closed)

Created:
4 years, 2 months ago by tikuta
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, ukai, shinyak, Yoshisato Yanagisawa
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

use_goma_module=True in chromium_libfuzzer_clang_tot This CL enables goma module for following buildbot https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASanLibfuzzer This change makes one big compile step using goma to small separated steps. BUG=656540 Committed: https://chromium.googlesource.com/chromium/tools/build/+/cbc5a0a3ff3f55f5059b1ce3fd0712084a6a4ea8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -33 lines) Patch
M scripts/slave/recipes/chromium_libfuzzer_clang_tot.py View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_libfuzzer_clang_tot.expected/full_chromium_fyi_ClangToTLinuxASanLibfuzzer.json View 1 chunk +137 lines, -32 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
tikuta
PTAL.
4 years, 2 months ago (2016-10-21 05:15:39 UTC) #4
Paweł Hajdan Jr.
LGTM
4 years, 2 months ago (2016-10-21 08:34:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438063004/1
4 years, 1 month ago (2016-10-25 05:43:15 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/cbc5a0a3ff3f55f5059b1ce3fd0712084a6a4ea8
4 years, 1 month ago (2016-10-25 05:55:33 UTC) #9
Dirk Pranke
4 years, 1 month ago (2016-10-26 19:00:02 UTC) #10
Message was sent while issue was closed.
lgtm also.

Powered by Google App Engine
This is Rietveld 408576698