Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 2438043003: Web MIDI: move device state adjustment code from content to Blink (Closed)

Created:
4 years, 2 months ago by Takashi Toyoshima
Modified:
4 years, 1 month ago
Reviewers:
yhirano
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, toyoshim+midi_chromium.org, posciak+watch_chromium.org, jam, haraken, feature-media-reviews_chromium.org, darin-cc_chromium.org, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web MIDI: move device state adjustment code from content to Blink This aims to reduce Web MIDI logics in content/renderer so to make coming mojofication change as much simple as possible. BUG=582327 Committed: https://crrev.com/e4f3fe1d0fdf0c0fa7aa6dbfaf48d6ea09d431b6 Cr-Commit-Position: refs/heads/master@{#430234}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -61 lines) Patch
M content/renderer/media/midi_message_filter.h View 1 chunk +0 lines, -9 lines 0 comments Download
M content/renderer/media/midi_message_filter.cc View 4 chunks +10 lines, -10 lines 0 comments Download
D content/renderer/media/midi_message_filter_unittest.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIAccess.cpp View 5 chunks +21 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Takashi Toyoshima
ptal
4 years, 1 month ago (2016-10-27 00:15:47 UTC) #11
yhirano
lgtm
4 years, 1 month ago (2016-10-31 10:30:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438043003/1
4 years, 1 month ago (2016-11-07 06:23:27 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 07:43:16 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 07:46:04 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e4f3fe1d0fdf0c0fa7aa6dbfaf48d6ea09d431b6
Cr-Commit-Position: refs/heads/master@{#430234}

Powered by Google App Engine
This is Rietveld 408576698