Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2438033003: [NOT FOR COMMIT] Layout test for WebFonts cache-aware timeout adaption (Closed)

Created:
4 years, 2 months ago by Shao-Chuan Lee
Modified:
4 years, 1 month ago
CC:
chromium-reviews, blink-reviews, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NOT FOR COMMIT] Layout test for WebFonts cache-aware timeout adaption Layout test to verify webfonts cache-aware display behavior. Since the behavior depends on disk cache latency in network stack, here we block normal FontResource callbacks and expose them through window.internals to control display behavior from JavaScript. BUG=570205

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase, new behavior #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Patch Set 8 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+385 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/http/tests/webfont/cache-aware-font-display.html View 1 chunk +86 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/webfont/cache-aware-font-display-expected.html View 1 2 3 1 chunk +165 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/core_idl_files.gni View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/FontResource.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/FontResource.cpp View 1 2 3 4 5 6 7 4 chunks +10 lines, -1 line 0 comments Download
A third_party/WebKit/Source/core/testing/CacheAwareFontDisplayTest.h View 1 2 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/testing/CacheAwareFontDisplayTest.cpp View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/testing/CacheAwareFontDisplayTest.idl View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 2 3 4 5 6 7 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.idl View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 33 (33 generated)
yhirano
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-10-25 02:02:28 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438033003/1
4 years, 1 month ago (2016-10-25 02:02:51 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-10-25 02:05:06 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cronet/builds/23691) ios-device on ...
4 years, 1 month ago (2016-10-25 02:05:07 UTC) #4
Shao-Chuan Lee
The CQ bit was checked by shaochuan@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-10-25 04:06:37 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438033003/20001
4 years, 1 month ago (2016-10-25 04:06:56 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-10-25 04:06:57 UTC) #7
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started ...
4 years, 1 month ago (2016-10-25 04:06:57 UTC) #8
yhirano
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-10-25 04:09:53 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438033003/20001
4 years, 1 month ago (2016-10-25 04:10:10 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-10-25 05:58:32 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 1 month ago (2016-10-25 05:58:33 UTC) #12
Shao-Chuan Lee
Description was changed from ========== WIP: Layout test for WebFonts cache-aware timeout adaption Layout test ...
4 years, 1 month ago (2016-11-07 08:35:29 UTC) #13
Shao-Chuan Lee
shaochuan@chromium.org changed reviewers: + ksakamoto@chromium.org
4 years, 1 month ago (2016-11-07 08:35:29 UTC) #14
Shao-Chuan Lee
The CQ bit was checked by shaochuan@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-15 05:44:18 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438033003/100001
4 years, 1 month ago (2016-11-15 05:44:44 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-15 05:44:45 UTC) #17
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started ...
4 years, 1 month ago (2016-11-15 05:44:46 UTC) #18
Kunihiko Sakamoto
The CQ bit was checked by ksakamoto@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-15 05:46:41 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438033003/100001
4 years, 1 month ago (2016-11-15 05:46:58 UTC) #20
Shao-Chuan Lee
The CQ bit was unchecked by shaochuan@chromium.org
4 years, 1 month ago (2016-11-15 06:03:12 UTC) #21
Kunihiko Sakamoto
The CQ bit was checked by ksakamoto@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-15 07:00:05 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438033003/120001
4 years, 1 month ago (2016-11-15 07:00:13 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-15 08:56:57 UTC) #24
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 1 month ago (2016-11-15 08:56:58 UTC) #25
Shao-Chuan Lee
The CQ bit was checked by shaochuan@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-16 04:45:22 UTC) #26
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438033003/140001
4 years, 1 month ago (2016-11-16 04:45:55 UTC) #27
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-16 04:45:56 UTC) #28
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started ...
4 years, 1 month ago (2016-11-16 04:45:56 UTC) #29
Takashi Toyoshima
The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-16 04:59:32 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438033003/140001
4 years, 1 month ago (2016-11-16 05:00:10 UTC) #31
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-16 06:58:14 UTC) #32
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 06:58:15 UTC) #33
Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698