Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2438023004: mash: Migrate ShowSetTimeDialog from SystemTrayDelegate to mojo (Closed)

Created:
4 years, 2 months ago by James Cook
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, msw
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Migrate ShowSetTimeDialog from SystemTrayDelegate to mojo This is part of the mustash refactoring of ash. Migrate to the existing SystemTrayClient mojo interface. BUG=647412 TEST=show time settings via system tray at the login screen Committed: https://crrev.com/3a3d9e2aeb2beee0db8288d57ff3f473b1841f0e Cr-Commit-Position: refs/heads/master@{#427104}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -16 lines) Patch
M ash/common/system/date/date_view.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ash/common/system/tray/system_tray_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/common/system/tray/system_tray_controller.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ash/common/system/tray/system_tray_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/common/system/tray/system_tray_delegate.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/public/interfaces/system_tray.mojom View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_client.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
James Cook
msw, please take a look at everything. tsepez, please take a look at ash/public/interfaces/system_tray.mojom
4 years, 2 months ago (2016-10-21 23:11:46 UTC) #3
msw
lgtm
4 years, 2 months ago (2016-10-21 23:22:50 UTC) #5
Tom Sepez
lgtm
4 years, 2 months ago (2016-10-22 00:12:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438023004/20001
4 years, 1 month ago (2016-10-24 17:57:42 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-24 18:46:01 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 18:54:13 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3a3d9e2aeb2beee0db8288d57ff3f473b1841f0e
Cr-Commit-Position: refs/heads/master@{#427104}

Powered by Google App Engine
This is Rietveld 408576698