Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2438023003: devtools: Adds Page.getLayoutMetrics. (Closed)

Created:
4 years, 2 months ago by Eric Seckler
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, darin-cc_chromium.org, kinuko+watch, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

devtools: Adds Page.getLayoutMetrics. This allows e.g. headless embedders to determine the position/dimension/scale of layout and visual viewport. BUG=546953 Committed: https://crrev.com/10f7e12361ee5e1eeb6955f0bc27eb3c182dd412 Cr-Commit-Position: refs/heads/master@{#428985}

Patch Set 1 #

Patch Set 2 : refactor commands to Page.getLayoutMetrics. #

Total comments: 6

Patch Set 3 : address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -3 lines) Patch
M content/browser/devtools/protocol/devtools_protocol_browsertest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/page/get-layout-metrics.html View 1 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/page/get-layout-metrics-expected.txt View 1 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 1 2 chunks +39 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 1 2 2 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
Eric Seckler
Dmitry, PTAL :) I'm adding methods for both layout and visual viewport, because both are ...
4 years, 2 months ago (2016-10-21 11:22:00 UTC) #4
dgozman
On 2016/10/21 11:22:00, Eric Seckler wrote: > Dmitry, PTAL :) > > I'm adding methods ...
4 years, 2 months ago (2016-10-21 20:29:23 UTC) #5
Eric Seckler
On 2016/10/21 20:29:23, dgozman wrote: > On 2016/10/21 11:22:00, Eric Seckler wrote: > > Dmitry, ...
4 years, 2 months ago (2016-10-21 22:03:21 UTC) #6
dgozman
On 2016/10/21 22:03:21, Eric Seckler wrote: > On 2016/10/21 20:29:23, dgozman wrote: > > On ...
4 years, 1 month ago (2016-10-24 18:10:36 UTC) #7
Eric Seckler
On 2016/10/24 18:10:36, dgozman wrote: > On 2016/10/21 22:03:21, Eric Seckler wrote: > > On ...
4 years, 1 month ago (2016-10-25 15:43:56 UTC) #15
dgozman
lgtm https://codereview.chromium.org/2438023003/diff/60001/third_party/WebKit/LayoutTests/inspector-protocol/page/get-layout-metrics-expected.txt File third_party/WebKit/LayoutTests/inspector-protocol/page/get-layout-metrics-expected.txt (right): https://codereview.chromium.org/2438023003/diff/60001/third_party/WebKit/LayoutTests/inspector-protocol/page/get-layout-metrics-expected.txt#newcode5 third_party/WebKit/LayoutTests/inspector-protocol/page/get-layout-metrics-expected.txt:5: clientWidth : 785 Could this flake on different ...
4 years, 1 month ago (2016-10-25 18:14:55 UTC) #16
Eric Seckler
https://codereview.chromium.org/2438023003/diff/60001/third_party/WebKit/LayoutTests/inspector-protocol/page/get-layout-metrics-expected.txt File third_party/WebKit/LayoutTests/inspector-protocol/page/get-layout-metrics-expected.txt (right): https://codereview.chromium.org/2438023003/diff/60001/third_party/WebKit/LayoutTests/inspector-protocol/page/get-layout-metrics-expected.txt#newcode5 third_party/WebKit/LayoutTests/inspector-protocol/page/get-layout-metrics-expected.txt:5: clientWidth : 785 On 2016/10/25 18:14:55, dgozman wrote: > ...
4 years, 1 month ago (2016-10-26 12:30:45 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438023003/80001
4 years, 1 month ago (2016-11-01 11:01:51 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 1 month ago (2016-11-01 12:17:22 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 12:19:05 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/10f7e12361ee5e1eeb6955f0bc27eb3c182dd412
Cr-Commit-Position: refs/heads/master@{#428985}

Powered by Google App Engine
This is Rietveld 408576698