Prevent FontResource load limit timers from restarting during loading

Prevent FontResource load limit timers from restarting during loading

FontResource::startLoadLimitTimersIfNeeded() was called from
RemoteFontFaceSource::beginLoadIfNeeded() on each style recalc, and bypasses
checks if called when FontResource is still loading and long limit timer has
fired. This may cause RemoteFontFaceSource callbacks to be called more than once
and in turn corrupt its internal state.
Now we start timers only after actual load of FontResource is started.

BUG=655076
Review-Url: https://codereview.chromium.org/2419753002
Cr-Commit-Position: refs/heads/master@{#425010}
(cherry picked from commit 6b2d64014d739051f120dc38df46ac73a469270d)

R=shaochuan@chromium.org
TBR=toyoshim@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/ed25c977e0d9c92aa15824a3722a7627f99fb8d1

[Takashi Toyoshima, 2016-10-20 04:50:06]

Description was changed from

==========
Prevent FontResource load limit timers from restarting during loading

FontResource::startLoadLimitTimersIfNeeded() was called from
RemoteFontFaceSource::beginLoadIfNeeded() on each style recalc, and bypasses
checks if called when FontResource is still loading and long limit timer has
fired. This may cause RemoteFontFaceSource callbacks to be called more than once
and in turn corrupt its internal state.
Now we start timers only after actual load of FontResource is started.

BUG=655076

Review-Url: https://codereview.chromium.org/2419753002
Cr-Commit-Position: refs/heads/master@{#425010}
(cherry picked from commit 6b2d64014d739051f120dc38df46ac73a469270d)
==========

to

==========
Prevent FontResource load limit timers from restarting during loading

FontResource::startLoadLimitTimersIfNeeded() was called from
RemoteFontFaceSource::beginLoadIfNeeded() on each style recalc, and bypasses
checks if called when FontResource is still loading and long limit timer has
fired. This may cause RemoteFontFaceSource callbacks to be called more than once
and in turn corrupt its internal state.
Now we start timers only after actual load of FontResource is started.

BUG=655076

Review-Url: https://codereview.chromium.org/2419753002
Cr-Commit-Position: refs/heads/master@{#425010}
(cherry picked from commit 6b2d64014d739051f120dc38df46ac73a469270d)
==========

[Takashi Toyoshima, 2016-10-20 04:50:07]

toyoshim@chromium.org changed reviewers:
+ shaochuan@chromium.org

[Shao-Chuan Lee, 2016-10-20 04:52:27]

On 2016/10/20 04:50:07, toyoshim wrote:
> mailto:toyoshim@chromium.org changed reviewers:
> + mailto:shaochuan@chromium.org

lgtm

[Takashi Toyoshima, 2016-10-20 04:53:18]

Description was changed from

==========
Prevent FontResource load limit timers from restarting during loading

FontResource::startLoadLimitTimersIfNeeded() was called from
RemoteFontFaceSource::beginLoadIfNeeded() on each style recalc, and bypasses
checks if called when FontResource is still loading and long limit timer has
fired. This may cause RemoteFontFaceSource callbacks to be called more than once
and in turn corrupt its internal state.
Now we start timers only after actual load of FontResource is started.

BUG=655076

Review-Url: https://codereview.chromium.org/2419753002
Cr-Commit-Position: refs/heads/master@{#425010}
(cherry picked from commit 6b2d64014d739051f120dc38df46ac73a469270d)
==========

to

==========
Prevent FontResource load limit timers from restarting during loading

FontResource::startLoadLimitTimersIfNeeded() was called from
RemoteFontFaceSource::beginLoadIfNeeded() on each style recalc, and bypasses
checks if called when FontResource is still loading and long limit timer has
fired. This may cause RemoteFontFaceSource callbacks to be called more than once
and in turn corrupt its internal state.
Now we start timers only after actual load of FontResource is started.

BUG=655076

Review-Url: https://codereview.chromium.org/2419753002
Cr-Commit-Position: refs/heads/master@{#425010}
(cherry picked from commit 6b2d64014d739051f120dc38df46ac73a469270d)

TBR=toyoshim@chromium.org
==========

[Takashi Toyoshima, 2016-10-20 04:58:54]

Description was changed from

==========
Prevent FontResource load limit timers from restarting during loading

FontResource::startLoadLimitTimersIfNeeded() was called from
RemoteFontFaceSource::beginLoadIfNeeded() on each style recalc, and bypasses
checks if called when FontResource is still loading and long limit timer has
fired. This may cause RemoteFontFaceSource callbacks to be called more than once
and in turn corrupt its internal state.
Now we start timers only after actual load of FontResource is started.

BUG=655076

Review-Url: https://codereview.chromium.org/2419753002
Cr-Commit-Position: refs/heads/master@{#425010}
(cherry picked from commit 6b2d64014d739051f120dc38df46ac73a469270d)

TBR=toyoshim@chromium.org
==========

to

==========
Prevent FontResource load limit timers from restarting during loading

FontResource::startLoadLimitTimersIfNeeded() was called from
RemoteFontFaceSource::beginLoadIfNeeded() on each style recalc, and bypasses
checks if called when FontResource is still loading and long limit timer has
fired. This may cause RemoteFontFaceSource callbacks to be called more than once
and in turn corrupt its internal state.
Now we start timers only after actual load of FontResource is started.

BUG=655076

Review-Url: https://codereview.chromium.org/2419753002
Cr-Commit-Position: refs/heads/master@{#425010}
(cherry picked from commit 6b2d64014d739051f120dc38df46ac73a469270d)

R=shaochuan@chromium.org
TBR=toyoshim@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/ed25c977e0d9c92aa15824a3722a...
==========

[Takashi Toyoshima, 2016-10-20 04:58:57]

Committed patchset #1 (id:1) manually as
ed25c977e0d9c92aa15824a3722a7627f99fb8d1 (presubmit successful).