Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 243793006: HTML Imports: Teach preloader about HTML Imports. (Closed)

Created:
6 years, 8 months ago by Hajime Morrita
Modified:
6 years, 8 months ago
Reviewers:
esprehn, dglazkov
CC:
blink-reviews, arv+blink, dglazkov+blink, adamk+blink_chromium.org, ojan, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

HTML Imports: Teach preloader about HTML Imports. This change tells HTMLPreloadScanner about <link rel=import> so that it can preload the resource for the import. TEST=import-preload.html R=esprehn@chromium.org,dglazkov@chromium.org BUG=323096 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172400

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -28 lines) Patch
M LayoutTests/http/tests/htmlimports/import-cors-credentials.html View 1 1 chunk +5 lines, -13 lines 0 comments Download
A LayoutTests/http/tests/htmlimports/import-preload.html View 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/htmlimports/import-preload-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/htmlimports/resources/hello.css View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/htmlimports/resources/hello.js View 1 chunk +3 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/htmlimports/resources/import-cors-credentials-body.html View 1 1 chunk +6 lines, -8 lines 0 comments Download
A LayoutTests/http/tests/htmlimports/resources/preload.html View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLPreloadScanner.cpp View 6 chunks +23 lines, -6 lines 0 comments Download
M Source/core/html/parser/HTMLResourcePreloader.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Hajime Morrita
PTAL?
6 years, 8 months ago (2014-04-21 23:24:02 UTC) #1
dglazkov
lgtm
6 years, 8 months ago (2014-04-21 23:33:52 UTC) #2
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 8 months ago (2014-04-21 23:42:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/243793006/1
6 years, 8 months ago (2014-04-21 23:42:47 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-21 23:52:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 8 months ago (2014-04-21 23:52:32 UTC) #6
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 8 months ago (2014-04-23 17:13:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/243793006/20001
6 years, 8 months ago (2014-04-23 17:14:08 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 21:08:59 UTC) #9
Message was sent while issue was closed. 
Change committed as 172400

Powered by Google App Engine
This is Rietveld 408576698