pkg/barback/test/transformer/rewrite.dart - Issue 243793005: Don't require Transformer methods to return Futures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/barback/test/transformer/rewrite.dart

Issue 243793005: Don't require Transformer methods to return Futures. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: code review Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/barback/test/transformer/rewrite.dart

diff --git a/pkg/barback/test/transformer/rewrite.dart b/pkg/barback/test/transformer/rewrite.dart

index 995c94fff0c92cd474df4e4aa1cc3a71370de048..d25a552a29f8e55cd46983fd1df91f255fca2db3 100644

--- a/pkg/barback/test/transformer/rewrite.dart

+++ b/pkg/barback/test/transformer/rewrite.dart

@@ -25,8 +25,7 @@ class RewriteTransformer extends MockTransformer {

/// created for each input.

RewriteTransformer(this.from, this.to);

- Future<bool> doIsPrimary(AssetId id) =>

- new Future.value(id.extension == ".$from");

+ bool doIsPrimary(AssetId id) => id.extension == ".$from";

Future doApply(Transform transform) {

return getPrimary(transform).then((input) {

« no previous file with comments | « pkg/barback/test/transformer/one_to_many.dart ('k') | pkg/barback/test/transformer/sync_rewrite.dart » ('j') | no next file with comments »