Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: pkg/barback/lib/src/declaring_transformer.dart

Issue 243793005: Don't require Transformer methods to return Futures. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/barback/CHANGELOG.md ('k') | pkg/barback/lib/src/transformer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/barback/lib/src/declaring_transformer.dart
diff --git a/pkg/barback/lib/src/declaring_transformer.dart b/pkg/barback/lib/src/declaring_transformer.dart
index a784493da9cf3268665ff14b545e6a433379da28..e3553e7810e9835fceb3133f607156f8030d77e2 100644
--- a/pkg/barback/lib/src/declaring_transformer.dart
+++ b/pkg/barback/lib/src/declaring_transformer.dart
@@ -21,5 +21,8 @@ abstract class DeclaringTransformer {
/// First, instead of having access to the primary input's contents, it only
/// has access to its id. Second, instead of emitting [Asset]s, it just emits
/// [AssetId]s through [transform.addOutputId].
- Future declareOutputs(DeclaringTransform transform);
+ ///
+ /// If this does asynchronous work, it should return a [Future] that completes
+ /// once it's finished.
+ declareOutputs(DeclaringTransform transform);
}
« no previous file with comments | « pkg/barback/CHANGELOG.md ('k') | pkg/barback/lib/src/transformer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698