Don't require Transformer methods to return Futures.

pkg/barback/test/transformer/bad.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library barback.test.transformer.bad;
 
-import 'dart:async';
-
 import 'package:barback/barback.dart';
-import 'package:barback/src/utils.dart';
 
 import 'mock.dart';
 
 /// A transformer that throws an exception when run, after generating the
 /// given outputs.
 class BadTransformer extends MockTransformer {

[Bob Nystrom, 2014/04/21 22:32:23]

A lot (all?) of the test transformers are sync now. Do we still have test
coverage for async transformers?

[nweiz, 2014/04/21 22:46:24]

They're actually still async, since they're wrapped by MockTransformer.

[Bob Nystrom, 2014/04/21 23:38:00]

Oh, well, in that case do we have any sync transformer test coverage? :)

[nweiz, 2014/04/21 23:49:41]

I guess not. Done.

   /// The error it throws.
   static const ERROR = "I am a bad transformer!";
 
   /// The list of asset names that it should output.
   final List<String> outputs;
 
   BadTransformer(this.outputs);
 
-  Future<bool> doIsPrimary(AssetId id) => new Future.value(true);
+  bool doIsPrimary(AssetId id) => true;
 
-  Future doApply(Transform transform) {
-    return newFuture(() {
-      // Create the outputs first.
-      for (var output in outputs) {
-        var id = new AssetId.parse(output);
-        transform.addOutput(new Asset.fromString(id, output));
-      }
+  void doApply(Transform transform) {
+    // Create the outputs first.
+    for (var output in outputs) {
+      var id = new AssetId.parse(output);
+      transform.addOutput(new Asset.fromString(id, output));
+    }
 
-      // Then fail.
-      throw ERROR;
-    });
+    // Then fail.
+    throw ERROR;
   }
 }