Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2437923004: Ntp: reset alpha and translation when rebinding action cards. (Closed)

Created:
4 years, 2 months ago by Michael van Ouwerkerk
Modified:
4 years, 1 month ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ntp: reset alpha and translation when rebinding action cards. BUG=655498 Committed: https://crrev.com/e381eb2b6fad4fdf6f9cca40dd41a1a9d9df120f Cr-Commit-Position: refs/heads/master@{#427071}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Michael van Ouwerkerk
Nicolas, could you take a look please?
4 years, 2 months ago (2016-10-20 14:50:13 UTC) #4
Michael van Ouwerkerk
Bernhard, could you take a look please?
4 years, 1 month ago (2016-10-24 12:55:33 UTC) #8
Bernhard Bauer
lgtm
4 years, 1 month ago (2016-10-24 12:57:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437923004/1
4 years, 1 month ago (2016-10-24 12:59:03 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 15:02:56 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 15:05:04 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e381eb2b6fad4fdf6f9cca40dd41a1a9d9df120f
Cr-Commit-Position: refs/heads/master@{#427071}

Powered by Google App Engine
This is Rietveld 408576698