Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Issue 2437923003: Adding new mac laptop VMs to perf waterfall. (Closed)

Created:
4 years, 2 months ago by eyaich1
Modified:
4 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Adding vm ids #

Patch Set 3 : Adding expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -65 lines) Patch
M masters/master.chromium.perf/master.cfg View 1 chunk +2 lines, -0 lines 0 comments Download
M masters/master.chromium.perf/slaves.cfg View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_perf.py View 2 chunks +8 lines, -0 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_perf_Mac_Air_10_11_Perf.json View 1 2 19 chunks +32 lines, -32 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Mac_Builder.json View 1 2 3 chunks +39 lines, -1 line 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_perf_Mac_Pro_10_11_Perf.json View 1 2 19 chunks +32 lines, -32 lines 0 comments Download

Messages

Total messages: 24 (10 generated)
eyaich1
4 years, 2 months ago (2016-10-20 14:59:41 UTC) #2
sullivan
cc-ing martiniss, bot health sheriff. This will require a master restart, and add the first ...
4 years, 2 months ago (2016-10-20 15:02:31 UTC) #4
sullivan
lgtm
4 years, 2 months ago (2016-10-20 15:31:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437923003/20001
4 years, 2 months ago (2016-10-20 15:33:33 UTC) #7
martiniss
On 2016/10/20 at 15:33:33, commit-bot wrote: > CQ is trying da patch. Follow status at ...
4 years, 2 months ago (2016-10-20 15:46:53 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/31fb94f1b0753b10)
4 years, 2 months ago (2016-10-20 16:17:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437923003/40001
4 years, 2 months ago (2016-10-20 17:49:15 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/31fc07cf65c68910)
4 years, 2 months ago (2016-10-20 18:24:51 UTC) #15
chromium-reviews
I need owners approval. Stephen are you on owner? Sent from my iPhone > On ...
4 years, 2 months ago (2016-10-20 18:27:46 UTC) #16
martiniss
Need chromium tests OWNER
4 years, 2 months ago (2016-10-20 18:28:44 UTC) #18
Sergey Berezin
I'm not a good reviewer for this, I'll defer to dtu@; or add others from ...
4 years, 2 months ago (2016-10-20 18:39:21 UTC) #19
ghost stip (do not use)
lgtm
4 years, 2 months ago (2016-10-20 19:02:40 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437923003/40001
4 years, 2 months ago (2016-10-20 19:40:44 UTC) #22
commit-bot: I haz the power
4 years, 2 months ago (2016-10-20 19:50:18 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/b50d874e4fdad1dfddc0...

Powered by Google App Engine
This is Rietveld 408576698