Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2437883002: Made PassRefPtr move only and replaced new copies with moves. (Closed)

Created:
4 years, 2 months ago by Bugs Nash
Modified:
4 years, 1 month ago
Reviewers:
haraken, Yuta Kitamura
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, blink-reviews-wtf_chromium.org, chromium-reviews, dglazkov+blink, Mikhail, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Made PassRefPtr move only and replaced new copies with moves. Removed PassRefPtr copy constructor. Added move wraps for remaining PassRefPtr copies (newly introduced). BUG=640449 Committed: https://crrev.com/f26988b540a3d5293179ddb7e9d5fc5203dcfb8b Cr-Commit-Position: refs/heads/master@{#427020}

Patch Set 1 #

Patch Set 2 : Removed stale comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M third_party/WebKit/Source/core/css/PropertyRegistry.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleNonInheritedVariables.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/BlobBytesConsumer.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FormDataBytesConsumer.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FormDataBytesConsumer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/wtf/PassRefPtr.h View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 24 (16 generated)
Bugs Nash
=D
4 years, 2 months ago (2016-10-19 21:58:19 UTC) #7
haraken
LGTM
4 years, 2 months ago (2016-10-20 04:23:14 UTC) #10
Yuta Kitamura
LGTM!
4 years, 2 months ago (2016-10-21 04:50:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437883002/20001
4 years, 2 months ago (2016-10-23 22:33:54 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/150971)
4 years, 2 months ago (2016-10-24 01:05:45 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437883002/20001
4 years, 1 month ago (2016-10-24 06:21:31 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-24 06:33:15 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 06:35:28 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f26988b540a3d5293179ddb7e9d5fc5203dcfb8b
Cr-Commit-Position: refs/heads/master@{#427020}

Powered by Google App Engine
This is Rietveld 408576698