Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.cpp

Issue 2437873008: Get rid of flat tree version of createVisibleSelection() taking two VisiblePosition (Closed)
Patch Set: 2016-10-21T16:03:11 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
index 7f07e42cdd127920c4dc9336024c32ecdbb05d92..efca708b6c19212817cfe8d4e238c97a2e3e12b3 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
@@ -98,15 +98,6 @@ VisibleSelection createVisibleSelection(const Position& base,
return createVisibleSelection(builder.build());
}
-VisibleSelection createVisibleSelection(const VisiblePosition& base,
- const VisiblePosition& extent,
- bool isDirectional) {
- DCHECK(base.isValid());
- DCHECK(extent.isValid());
- return createVisibleSelection(base.deepEquivalent(), extent.deepEquivalent(),
- base.affinity(), isDirectional);
-}
-
VisibleSelectionInFlatTree createVisibleSelection(
const SelectionInFlatTree& selection) {
return VisibleSelectionInFlatTree::create(selection);

Powered by Google App Engine
This is Rietveld 408576698