Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: media/base/audio_renderer_sink.h

Issue 2437863004: Make more media APIs aware of |delay| and |delay_timestamp| (Closed)
Patch Set: Review comments + build fixes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/audio_renderer_sink.h
diff --git a/media/base/audio_renderer_sink.h b/media/base/audio_renderer_sink.h
index f768b7cb1b42d2f0fbb4d7f192b2df5a1d7840ab..9c4eceb67c008b30d04d547c94b3d8954ad3e0cb 100644
--- a/media/base/audio_renderer_sink.h
+++ b/media/base/audio_renderer_sink.h
@@ -28,14 +28,15 @@ class AudioRendererSink
class RenderCallback {
public:
// Attempts to completely fill all channels of |dest|, returns actual
- // number of frames filled. |frames_skipped| contains the number of frames
+ // number of frames filled. |prior_frames_skipped| contains the number of
+ // frames
// the consumer has skipped, if any.
- // TODO(jameswest): Change to use the same signature as
- // AudioOutputStream::AudioSourceCallback::OnMoreData.
- virtual int Render(AudioBus* dest,
- uint32_t frames_delayed,
- uint32_t frames_skipped) = 0;
-
+ // The |delay| argument represents audio device output latency,
+ // |delay_timestamp| represents the time when |delay| was obtained.
+ virtual int Render(base::TimeDelta delay,
+ base::TimeTicks delay_timestamp,
+ uint32_t prior_frames_skipped,
James West 2016/10/24 21:05:45 Use int instead of uint32_t.
Mikhail 2016/10/25 07:46:10 Done.
+ AudioBus* dest) = 0;
// Signals an error has occurred.
virtual void OnRenderError() = 0;

Powered by Google App Engine
This is Rietveld 408576698