Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: pkg/compiler/lib/src/js_backend/backend.dart

Issue 2437863002: Prevent inlining of js_library core.RegExp constructor (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/js_runtime/lib/core_patch.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/backend.dart
diff --git a/pkg/compiler/lib/src/js_backend/backend.dart b/pkg/compiler/lib/src/js_backend/backend.dart
index fe3684afbe7aee6aac962eace26304451347359d..6ac1c1565c33a6a71461114535f1fa09e9a05d09 100644
--- a/pkg/compiler/lib/src/js_backend/backend.dart
+++ b/pkg/compiler/lib/src/js_backend/backend.dart
@@ -2490,9 +2490,11 @@ class JavaScriptBackend extends Backend {
return;
}
- if ((element.isFunction || element.isConstructor) &&
- annotations.noInline(element)) {
- inlineCache.markAsNonInlinable(element);
+ Element implementation = element.implementation;
+ if (element.isFunction || element.isConstructor) {
+ if (annotations.noInline(implementation)) {
+ inlineCache.markAsNonInlinable(implementation);
+ }
}
LibraryElement library = element.library;
« no previous file with comments | « no previous file | sdk/lib/_internal/js_runtime/lib/core_patch.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698