Issue 2437863002: Prevent inlining of js_library core.RegExp constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2437863002: Prevent inlining of js_library core.RegExp constructor (Closed)

Created:
4 years, 2 months ago by sra1

Modified:
4 years, 2 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Prevent inlining of js_library core.RegExp constructor Inlining was achieving no beneficial effect. - Enabled GVN of match start. - Made string quote style uniform. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/50e557d176c6301bc8025bef2e75fcb1d2b5d26a

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -21 lines)			Patch
M	pkg/compiler/lib/src/js_backend/backend.dart	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/js_runtime/lib/core_patch.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/js_runtime/lib/regexp_helper.dart	View	6 chunks	+23 lines, -18 lines	0 comments	Download

Total messages: 5 (2 generated)

sra1

4 years, 2 months ago (2016-10-19 23:25:26 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
50e557d176c6301bc8025bef2e75fcb1d2b5d26a (presubmit successful).