Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 2437793002: Handle default formal parameters in LocalElementBuilder (Closed)

Created:
4 years, 2 months ago by Paul Berry
Modified:
4 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle default formal parameters in LocalElementBuilder Fixes #27615. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/4054d93fc9d3c22c8298ed95eba7276ff045f5ce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M pkg/analyzer/lib/src/dart/element/builder.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/analyzer/test/dart/element/builder_test.dart View 1 chunk +26 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 2 months ago (2016-10-19 18:10:58 UTC) #2
scheglov
LGTM
4 years, 2 months ago (2016-10-19 18:12:21 UTC) #3
Paul Berry
4 years, 2 months ago (2016-10-19 18:17:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4054d93fc9d3c22c8298ed95eba7276ff045f5ce (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698