Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Issue 2437783002: DevTools Disable cache should properly handle LoadOnlyFromCache resources (Closed)

Created:
4 years, 2 months ago by jkarlin
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, tyoshino+watch_chromium.org, Yoav Weiss, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, caseq+blink_chromium.org, apavlov+blink_chromium.org, gavinp+loader_chromium.org, devtools-reviews_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

DevTools Disable cache should properly handle LoadOnlyFromCache resources Currently, checking the "disable cache" button on the networking page in dev tools causes all requests to run with a bypass cache directive. Even those resources meant to be fetched exclusively from the cache. This means resources meant to be served only from the cache wind up being served from the network. This CL causes such requests to fail early, as would happen if the object were not in cache. BUG=634189 Review-Url: https://codereview.chromium.org/2266913002 Cr-Commit-Position: refs/heads/master@{#425706} (cherry picked from commit 938a1f2e20387f1008f4d34536b705da109792ac) Committed: https://chromium.googlesource.com/chromium/src/+/87b20b798d7d9c054bdea42b20b7ad9c772077c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 3 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jkarlin
4 years, 2 months ago (2016-10-19 18:12:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
87b20b798d7d9c054bdea42b20b7ad9c772077c7.

Powered by Google App Engine
This is Rietveld 408576698