Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Unified Diff: runtime/vm/runtime_entry_arm64.cc

Issue 243773002: Adds Runtime call stub and Dart entry stub to ARM64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/runtime_entry_arm64.cc
===================================================================
--- runtime/vm/runtime_entry_arm64.cc (revision 35155)
+++ runtime/vm/runtime_entry_arm64.cc (working copy)
@@ -15,8 +15,41 @@
#define __ assembler->
+// Generate code to call into the stub which will call the runtime
+// function. Input for the stub is as follows:
+// SP : points to the arguments and return value array.
+// R5 : address of the runtime function to call.
+// R4 : number of arguments to the call.
void RuntimeEntry::Call(Assembler* assembler, intptr_t argument_count) const {
- UNIMPLEMENTED();
+ // Compute the effective address. When running under the simulator,
+ // this is a redirection address that forces the simulator to call
+ // into the runtime system.
+ uword entry = GetEntryPoint();
+#if defined(USING_SIMULATOR)
+ // Redirection to leaf runtime calls supports a maximum of 4 arguments passed
+ // in registers (maximum 2 double arguments for leaf float runtime calls).
regis 2014/04/18 22:15:30 Di you verify this comment? The ARM64 ABI may be d
zra 2014/04/18 23:24:21 The ABI allows 8 register arguments for both integ
+ ASSERT(argument_count >= 0);
+ ASSERT(!is_leaf() ||
+ (!is_float() && (argument_count <= 4)) ||
+ (argument_count <= 2));
+ Simulator::CallKind call_kind =
+ is_leaf() ? (is_float() ? Simulator::kLeafFloatRuntimeCall
+ : Simulator::kLeafRuntimeCall)
+ : Simulator::kRuntimeCall;
+ entry =
+ Simulator::RedirectExternalReference(entry, call_kind, argument_count);
+#endif
+ if (is_leaf()) {
+ ASSERT(argument_count == this->argument_count());
+ ExternalLabel label(name(), entry);
+ __ BranchLink(&label, PP);
+ } else {
+ // Argument count is not checked here, but in the runtime entry for a more
+ // informative error message.
+ __ LoadImmediate(R5, entry, PP);
+ __ LoadImmediate(R4, argument_count, PP);
+ __ BranchLink(&StubCode::CallToRuntimeLabel(), PP);
+ }
}
} // namespace dart

Powered by Google App Engine
This is Rietveld 408576698