Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 243763002: Remove {big5,gb2312}han collation data (Closed)

Created:
6 years, 8 months ago by jungshik at Google
Modified:
6 years, 8 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Visibility:
Public.

Description

Remove {big5,gb2312}han collation data 1. {big5,gb2312}han collation data is not used by anybody because they're useless as a sorting order. Add a function to trim_data.sh to remove them from zh.txt 2. Remove remove_unihan.sh and add back unihan rules to coll/{zh,ja,ko}.txt. In ICU 52, tools/genrb does NOT include unihan collation by default so that we don't have to bother to remove it from the rule files. 3. Remove obsolete patch files (locale[23].patch) 4. Add LICENSE file (converted from license.html) 5. Update README.chromium accordingly. 6. Check in the updated data file/assembly files. The net saving in icudtl.dat is ~ 220kB. BUG=132145 TEST=icudtl.dat is 10576480 TBR=mark Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264857

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16678 lines, -18174 lines) Patch
A icu52/LICENSE View 1 chunk +386 lines, -0 lines 0 comments Download
M icu52/README.chromium View 6 chunks +15 lines, -17 lines 0 comments Download
D icu52/patches/locale2.patch View 1 chunk +0 lines, -17457 lines 0 comments Download
D icu52/patches/locale3.patch View 1 chunk +0 lines, -654 lines 0 comments Download
D icu52/scripts/remove_unihan.sh View 1 chunk +0 lines, -14 lines 0 comments Download
M icu52/scripts/trim_data.sh View 2 chunks +11 lines, -0 lines 0 comments Download
M icu52/source/data/coll/ja.txt View 1 chunk +5711 lines, -0 lines 0 comments Download
M icu52/source/data/coll/ko.txt View 1 chunk +5273 lines, -0 lines 0 comments Download
M icu52/source/data/coll/zh.txt View 2 chunks +5282 lines, -32 lines 0 comments Download
M icu52/source/data/in/icudtl.dat View Binary file 0 comments Download

Messages

Total messages: 3 (0 generated)
jungshik at Google
6 years, 8 months ago (2014-04-18 21:18:58 UTC) #1
jungshik at Google
Committed patchset #1 manually as r264857 (presubmit successful).
6 years, 8 months ago (2014-04-18 21:19:28 UTC) #2
Mark Mentovai
6 years, 8 months ago (2014-04-18 21:38:46 UTC) #3
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698