Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 24376002: [Retry] FileAPI: Add WebFileSystem::resolveURL (Closed)

Created:
7 years, 3 months ago by nhiroki
Modified:
7 years, 3 months ago
CC:
blink-reviews, kinuko, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[Retry] FileAPI: Add WebFileSystem::resolveURL NOTE: There is no change from the original patch: https://codereview.chromium.org/23537011/ This introduces WebFileSystem::resolveURL so that resolveLocalFileSystemURL, a member of FileSystem API, can resolve a filesystem URL for external filesystem. This includes: - Cracking the given filesystem URL not in Blink side but in Chromium side so that we can get more specific external filesystem type (e.g. SyncFileSystem). It is necessary to resolve the external filesystem URL. - Replacing readFileSystem with resolveURL since it's used only to resolve URLs. - Changing the error code, and these must be correct: (http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#errors-and-exceptions) Depends on Chromium side change: https://codereview.chromium.org/23526076/ BUG=177137 TEST=run_webkit_tests.sh http/tests/filesystem/\* TEST=run_webkit_tests.sh http/tests/inspector/filesystem/\* TBR=kinuko@chromium.org,tzik@chromium.org,abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158278

Patch Set 1 #

Messages

Total messages: 3 (0 generated)
nhiroki
TBR-ing to original reviewers (kinuko@, tzik@, abarth@) There is no difference from the original patch. ...
7 years, 3 months ago (2013-09-24 15:34:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/24376002/1
7 years, 3 months ago (2013-09-24 15:35:02 UTC) #2
commit-bot: I haz the power
7 years, 3 months ago (2013-09-24 15:39:37 UTC) #3
Message was sent while issue was closed.
Change committed as 158278

Powered by Google App Engine
This is Rietveld 408576698