chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java - Issue 2437593007: [Payments] Field trial and flag to abort payment request if no card.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

Issue 2437593007: [Payments] Field trial and flag to abort payment request if no card. (Closed)

Patch Set: Addressed comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java ('k') | chrome/android/java_sources.gni » ('j') | chrome/app/generated_resources.grd » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

index 44bc75d4b1ef2bfa34541677372ae808c686100a..0137f56c6c094a0e0ec1de23dcdbb6949abe91b5 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

@@ -18,6 +18,7 @@ import org.chromium.base.VisibleForTesting;

import org.chromium.base.metrics.RecordHistogram;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.ChromeActivity;

+import org.chromium.chrome.browser.ChromeFeatureList;

import org.chromium.chrome.browser.autofill.PersonalDataManager;

import org.chromium.chrome.browser.autofill.PersonalDataManager.AutofillProfile;

import org.chromium.chrome.browser.autofill.PersonalDataManager.NormalizedAddressRequestDelegate;

@@ -1013,10 +1014,12 @@ public class PaymentRequestImpl implements PaymentRequest, PaymentRequestUI.Clie

boolean waitingForPaymentApps = !mPendingApps.isEmpty() || !mPendingInstruments.isEmpty();

boolean foundPaymentMethods =

mPaymentMethodsSection != null && !mPaymentMethodsSection.isEmpty();

+ boolean userCanAddCreditCard = mMerchantSupportsAutofillPaymentInstruments

+ && !ChromeFeatureList.isEnabled(ChromeFeatureList.NO_CREDIT_CARD_ABORT);

if (!mArePaymentMethodsSupported

|| (mIsShowing && !waitingForPaymentApps && !foundPaymentMethods

- && !mMerchantSupportsAutofillPaymentInstruments)) {

+ && !userCanAddCreditCard)) {

// All payment apps have responded, but none of them have instruments. It's possible to

// add credit cards, but the merchant does not support them either. The payment request

// must be rejected.