[Payments] Field trial and flag to abort payment request if no card.

chrome/browser/about_flags.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/about_flags.h"
 
 #include <iterator>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 2054 matching lines @@
     {"enumerate-audio-devices", IDS_FLAGS_ENABLE_ENUMERATING_AUDIO_DEVICES_NAME,
      IDS_FLAGS_ENABLE_ENUMERATING_AUDIO_DEVICES_DESCRIPTION, kOsCrOS,
      FEATURE_VALUE_TYPE(features::kEnumerateAudioDevices)},
 #endif  // OS_CHROMEOS
 #if !defined(OS_ANDROID)
     {"enable-default-media-session",
      IDS_FLAGS_ENABLE_DEFAULT_MEDIA_SESSION_NAME,
      IDS_FLAGS_ENABLE_DEFAULT_MEDIA_SESSION_DESCRIPTION, kOsDesktop,
      MULTI_VALUE_TYPE(kEnableDefaultMediaSessionChoices)},
 #endif  // !defined(OS_ANDROID)
+#if defined(OS_ANDROID)
+    {"enable-no-card-abort", IDS_FLAGS_NO_CARD_ABORT,

[please use gerrit instead, 2016/10/20 20:27:44]

The "enable-no-card-abort" is used to generate a quick access URL for the
feature:

chrome://flags#enable-no-card-abort

The feature can be disabled, but the URL will remain the same, with "enable"
keyword in there. That's inconsistent. Let's remove the "enable" keyword from
the URL.

chrome://flags#no-card-abort

[sebsg, 2016/10/21 02:20:32]

Done.

+    IDS_FLAGS_NO_CARD_ABORT_DESCRIPTION, kOsAndroid,
+    ENABLE_DISABLE_VALUE_TYPE(switches::kEnablePaymentRequestNoCardAbort,

[please use gerrit instead, 2016/10/20 20:27:44]

You can use FEATURE_VALUE_TYPE() with ChromeFeatureList.

[sebsg, 2016/10/21 02:20:32]

Done.

+                              switches::kDisablePaymentRequestNoCardAbort)},
+#endif  // OS_ANDROID
     // NOTE: Adding new command-line switches requires adding corresponding
     // entries to enum "LoginCustomFlags" in histograms.xml. See note in
     // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
 };
 
 class FlagsStateSingleton {
  public:
   FlagsStateSingleton()
       : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {}
   ~FlagsStateSingleton() {}
@@ skipping 188 matching lines @@
 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
 
 const FeatureEntry* GetFeatureEntries(size_t* count) {
   *count = arraysize(kFeatureEntries);
   return kFeatureEntries;
 }
 
 }  // namespace testing
 
 }  // namespace about_flags