[Payments] Field trial and flag to abort payment request if no card.

chrome/browser/android/chrome_feature_list.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/chrome_feature_list.h"
 
 #include <stddef.h>
 
 #include <string>
 
@@ skipping 13 matching lines @@
 
 namespace chrome {
 namespace android {
 
 namespace {
 
 // Array of features exposed through the Java ChromeFeatureList API. Entries in
 // this array may either refer to features defined in the header of this file or
 // in other locations in the code base (e.g. chrome/, components/, etc).
 const base::Feature* kFeaturesExposedToJava[] = {
-    &autofill::kAutofillScanCardholderName,
-    &features::kAutoplayMutedVideos,
-    &features::kCredentialManagementAPI,
-    &features::kSimplifiedFullscreenUI,
-    &features::kWebPayments,
     &kAndroidPayIntegrationV1,
+    &kCCTExternalLinkHandling,
     &kChromeHomeFeature,
     &kDownloadsUiFeature,
     &kImportantSitesInCBD,
-    &ntp_snippets::kContentSuggestionsFeature,
-    &ntp_snippets::kSaveToOfflineFeature,
-    &ntp_snippets::kSectionDismissalFeature,
+    &kNoCreditCardAbort,
     &kNTPFakeOmniboxTextFeature,
     &kNTPOfflinePagesFeature,
     &kPhysicalWebFeature,
     &kPhysicalWebIgnoreOtherClientsFeature,
     &kScanCardsInWebPayments,
     &kSpecialLocaleFeature,
     &kSpecialLocaleWrapper,
     &kTabReparenting,
-    &kCCTExternalLinkHandling,
+    &autofill::kAutofillScanCardholderName,

[please use gerrit instead, 2016/10/21 19:00:20]

What kind of sorting puts "a" below "k"? :-P

[sebsg, 2016/10/25 15:13:09]

I saw it like the include files where you would include
   chrome/browser/text.h 
before
   chrome/browser/test/test.h

Happy to change it

+    &features::kAutoplayMutedVideos,
+    &features::kCredentialManagementAPI,
+    &features::kSimplifiedFullscreenUI,
+    &features::kWebPayments,
+    &ntp_snippets::kContentSuggestionsFeature,
+    &ntp_snippets::kSaveToOfflineFeature,
+    &ntp_snippets::kSectionDismissalFeature,
+    &offline_pages::kBackgroundLoaderForDownloadsFeature,
     &offline_pages::kOfflinePagesBackgroundLoadingFeature,
-    &offline_pages::kBackgroundLoaderForDownloadsFeature,
     &offline_pages::kOfflinePagesCTFeature,  // See crbug.com/620421.
     &offline_pages::kOfflinePagesSharingFeature,
     &password_manager::features::kViewPasswords,
 };
 
 }  // namespace
 
 const base::Feature kAndroidPayIntegrationV1{"AndroidPayIntegrationV1",
                                              base::FEATURE_ENABLED_BY_DEFAULT};
 
+const base::Feature kCCTExternalLinkHandling{"CCTExternalLinkHandling",
+                                             base::FEATURE_ENABLED_BY_DEFAULT};
+
 const base::Feature kChromeHomeFeature{"ChromeHome",
                                        base::FEATURE_DISABLED_BY_DEFAULT};
 
 const base::Feature kDownloadsUiFeature{"DownloadsUi",
                                          base::FEATURE_DISABLED_BY_DEFAULT};
 
 const base::Feature kImportantSitesInCBD{"ImportantSitesInCBD",
                                          base::FEATURE_DISABLED_BY_DEFAULT};
 
+const base::Feature kNoCreditCardAbort{"NoCreditCardAbort",
+                                       base::FEATURE_DISABLED_BY_DEFAULT};
+
 const base::Feature kNTPOfflinePagesFeature{"NTPOfflinePages",
                                             base::FEATURE_DISABLED_BY_DEFAULT};
 
 const base::Feature kNTPFakeOmniboxTextFeature{
     "NTPFakeOmniboxText", base::FEATURE_DISABLED_BY_DEFAULT};
 
 const base::Feature kPhysicalWebFeature{"PhysicalWeb",
                                         base::FEATURE_ENABLED_BY_DEFAULT};
 
 const base::Feature kPhysicalWebIgnoreOtherClientsFeature{
     "PhysicalWebIgnoreOtherClients", base::FEATURE_DISABLED_BY_DEFAULT};
 
 const base::Feature kScanCardsInWebPayments{"ScanCardsInWebPayments",
                                             base::FEATURE_DISABLED_BY_DEFAULT};
 
 const base::Feature kSpecialLocaleFeature{"SpecialLocale",
                                           base::FEATURE_DISABLED_BY_DEFAULT};
 
 const base::Feature kSpecialLocaleWrapper{"SpecialLocaleWrapper",
                                           base::FEATURE_ENABLED_BY_DEFAULT};
 
 const base::Feature kTabReparenting{"TabReparenting",
                                     base::FEATURE_ENABLED_BY_DEFAULT};
 
-const base::Feature kCCTExternalLinkHandling{"CCTExternalLinkHandling",
-                                    base::FEATURE_ENABLED_BY_DEFAULT};
-
 const base::Feature kUserMediaScreenCapturing{
     "UserMediaScreenCapturing", base::FEATURE_DISABLED_BY_DEFAULT};
 
 static jboolean IsEnabled(JNIEnv* env,
                           const JavaParamRef<jclass>& clazz,
                           const JavaParamRef<jstring>& jfeature_name) {
   const std::string feature_name = ConvertJavaStringToUTF8(env, jfeature_name);
   for (size_t i = 0; i < arraysize(kFeaturesExposedToJava); ++i) {
     if (kFeaturesExposedToJava[i]->name == feature_name)
       return base::FeatureList::IsEnabled(*kFeaturesExposedToJava[i]);
   }
   // Features queried via this API must be present in |kFeaturesExposedToJava|.
   NOTREACHED();
   return false;
 }
 
 bool RegisterChromeFeatureListJni(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace android
 }  // namespace chrome