Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 243743005: HttpServer: allows sending raw response data for streamed responses. (Closed)

Created:
6 years, 8 months ago by gunsch
Modified:
6 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

HttpServer: allows sending raw response data for streamed responses. Note: this was cloned from https://codereview.chromium.org/212683006/, which was reverted for ASAN issues. Patch-set 1 is the original CL, patch-set 2 is the ASAN fixes. BUG=347770 R=rsleevi@chromium.org,lcwu@chromium.org,mef@chromium.org,byungchul@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264910

Patch Set 1 #

Patch Set 2 : ASAN fixes. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -19 lines) Patch
M net/server/http_server.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/server/http_server.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M net/server/http_server_unittest.cc View 1 13 chunks +100 lines, -19 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
gunsch
6 years, 8 months ago (2014-04-18 23:51:52 UTC) #1
Ryan Sleevi
Wow, I'm really disappointed I missed that. LGTM.
6 years, 8 months ago (2014-04-18 23:56:58 UTC) #2
gunsch
The CQ bit was checked by gunsch@chromium.org
6 years, 8 months ago (2014-04-19 00:06:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/243743005/20001
6 years, 8 months ago (2014-04-19 00:07:12 UTC) #4
byungchul
https://codereview.chromium.org/243743005/diff/20001/net/server/http_server_unittest.cc File net/server/http_server_unittest.cc (right): https://codereview.chromium.org/243743005/diff/20001/net/server/http_server_unittest.cc#newcode99 net/server/http_server_unittest.cc:99: *message = std::string(read_buffer_->data(), bytes_received); message->assign(read_buffer_->data(), bytes_received);
6 years, 8 months ago (2014-04-19 00:09:48 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-19 02:12:43 UTC) #6
Message was sent while issue was closed.
Change committed as 264910

Powered by Google App Engine
This is Rietveld 408576698