[Android] Pass devil adb path to the gtest perf tests.

[Android] Pass devil adb path to the gtest perf tests.

BUG=623989
TBR=dpranke@chromium.org

Committed: https://crrev.com/bbfe58e45d941561fc1da92e118ae70ca28d1d20
Cr-Commit-Position: refs/heads/master@{#427218}

[jbudorick, 2016-10-21 16:31:40]

jbudorick@chromium.org changed reviewers:
+ dtu@chromium.org

[jbudorick, 2016-10-21 21:50:50]

jbudorick@chromium.org changed reviewers:
+ dpranke@chromium.org

[jbudorick, 2016-10-21 21:50:51]

+dpranke

[dtu, 2016-10-21 23:58:13]

lgtm

[jbudorick, 2016-10-24 18:06:08]

jbudorick@chromium.org changed reviewers:
+ iannucci@chromium.org, stip@chromium.org

[jbudorick, 2016-10-24 18:06:09]

Dirk appears to be ooo, so ptal:
 +iannucci for testing/scripts/ owners
 +stip for testing/buildbot/ owners

[ghost stip (do not use), 2016-10-24 18:44:05]

testing/buildbot owners lgtm, but can you check what's up with the hostname?

https://codereview.chromium.org/2437383002/diff/1/testing/buildbot/chromium.p...
File testing/buildbot/chromium.perf.fyi.json (right):

https://codereview.chromium.org/2437383002/diff/1/testing/buildbot/chromium.p...
testing/buildbot/chromium.perf.fyi.json:215: "id": "build171-b4",
I'm surprised by this

[jbudorick, 2016-10-24 21:47:57]

Description was changed from

==========
[Android] Pass devil adb path to the gtest perf tests.

BUG=623989
==========

to

==========
[Android] Pass devil adb path to the gtest perf tests.

BUG=623989
TBR=dpranke@chromium.org
==========

[jbudorick, 2016-10-24 21:48:38]

TBR dpranke for minor OWNERS review in //testing/scripts/

https://codereview.chromium.org/2437383002/diff/1/testing/buildbot/chromium.p...
File testing/buildbot/chromium.perf.fyi.json (right):

https://codereview.chromium.org/2437383002/diff/1/testing/buildbot/chromium.p...
testing/buildbot/chromium.perf.fyi.json:215: "id": "build171-b4",
On 2016/10/24 18:44:05, stip wrote:
> I'm surprised by this

As am I; looks like this may not be ready yet given that eyaich pulled it out of
https://chromiumcodereview.appspot.com/2439733002

[jbudorick, 2016-10-24 21:49:29]

The CQ bit was checked by jbudorick@chromium.org

[jbudorick, 2016-10-24 21:49:29]

The patchset sent to the CQ was uploaded after l-g-t-m from dtu@chromium.org,
stip@chromium.org
Link to the patchset: https://codereview.chromium.org/2437383002/#ps20001
(title: "stip comment")

[commit-bot: I haz the power, 2016-10-24 21:50:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 01:34:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-25 01:36:34]

Description was changed from

==========
[Android] Pass devil adb path to the gtest perf tests.

BUG=623989
TBR=dpranke@chromium.org
==========

to

==========
[Android] Pass devil adb path to the gtest perf tests.

BUG=623989
TBR=dpranke@chromium.org

Committed: https://crrev.com/bbfe58e45d941561fc1da92e118ae70ca28d1d20
Cr-Commit-Position: refs/heads/master@{#427218}
==========

[commit-bot: I haz the power, 2016-10-25 01:36:35]

Patchset 2 (id:??) landed as
https://crrev.com/bbfe58e45d941561fc1da92e118ae70ca28d1d20
Cr-Commit-Position: refs/heads/master@{#427218}

[Dirk Pranke, 2016-10-26 18:45:18]

https://codereview.chromium.org/2437383002/diff/20001/testing/buildbot/chromi...
File testing/buildbot/chromium.perf.json (right):

https://codereview.chromium.org/2437383002/diff/20001/testing/buildbot/chromi...
testing/buildbot/chromium.perf.json:10:
"src/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb"
Can we add --adb-path automatically in gtest_perf_test.py, or do we only need
this for some steps and not others?

I think I don't really understand what the background for this change is ...

[jbudorick, 2016-10-27 00:19:21]

https://codereview.chromium.org/2437383002/diff/20001/testing/buildbot/chromi...
File testing/buildbot/chromium.perf.json (right):

https://codereview.chromium.org/2437383002/diff/20001/testing/buildbot/chromi...
testing/buildbot/chromium.perf.json:10:
"src/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb"
On 2016/10/26 18:45:18, Dirk Pranke wrote:
> Can we add --adb-path automatically in gtest_perf_test.py, or do we only need
> this for some steps and not others?

Ideally, we only need this for some bots and not others & this would be
transparently passed down from the recipe. That appeared to be a significantly
larger can of worms, though.

> 
> I think I don't really understand what the background for this change is ...

stip and I are in the middle of rolling to the N SDK (the linked bug). That
rolls a new version of adb into *most* uses of adb in chromium (including this
one if no alternative adb path is specified). Telemetry, however, uses a
different adb path. When an adb client invocation sees an adb server of a
different version, it kills it, often with catastrophic results. We need
everything in a given build to use the same adb path that telemetry uses to
prevent that from happening while I work on a longer term fix that allows
telemetry's adb path to be configured (
(https://github.com/catapult-project/catapult/issues/2901).

[Dirk Pranke, 2016-10-27 00:34:01]

got it, thanks.

lgtm (belatedly).