Issue 2437313002: base::Optional operator bool doesn't convert to bool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2437313002: base::Optional operator bool doesn't convert to bool. (Closed)

Created:
4 years, 2 months ago by scheib

Modified:
4 years, 2 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

base::Optional operator bool doesn't convert to bool. NOT YET FOR LANDING, demonstrating the compile issue. BUG=658116

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -0 lines)			Patch
	M	base/optional_unittest.cc	View		1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scheib

The CQ bit was checked by scheib@chromium.org to run a CQ dry run

4 years, 2 months ago (2016-10-21 04:23:32 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437313002/1

4 years, 2 months ago (2016-10-21 04:23:50 UTC) #2

scheib

Description was changed from ========== base::Optional operator bool doesn't convert to bool. NOT YET FOR ...

4 years, 2 months ago (2016-10-21 04:28:44 UTC) #3

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 2 months ago (2016-10-21 04:28:45 UTC) #4

commit-bot: I haz the power

4 years, 2 months ago (2016-10-21 04:28:45 UTC) #5

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages