Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: content/test/content_browser_test_utils_internal.cc

Issue 2437253002: Improve TDI render process naming in the task manager. (Closed)
Patch Set: ncarter Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/public/browser/site_instance.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/test/content_browser_test_utils_internal.h" 5 #include "content/test/content_browser_test_utils_internal.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <map> 10 #include <map>
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
221 result.append("\n"); 221 result.append("\n");
222 result.append(line); 222 result.append(line);
223 } 223 }
224 224
225 // Finally, show a legend with details of the site instances. 225 // Finally, show a legend with details of the site instances.
226 const char* prefix = "Where "; 226 const char* prefix = "Where ";
227 for (auto& legend_entry : legend) { 227 for (auto& legend_entry : legend) {
228 SiteInstanceImpl* site_instance = 228 SiteInstanceImpl* site_instance =
229 static_cast<SiteInstanceImpl*>(legend_entry.second); 229 static_cast<SiteInstanceImpl*>(legend_entry.second);
230 std::string description = site_instance->GetSiteURL().spec(); 230 std::string description = site_instance->GetSiteURL().spec();
231 if (site_instance->is_default_subframe_site_instance()) 231 if (site_instance->IsDefaultSubframeSiteInstance())
232 description = "default subframe process"; 232 description = "default subframe process";
233 base::StringAppendF(&result, "\n%s%s = %s", prefix, 233 base::StringAppendF(&result, "\n%s%s = %s", prefix,
234 legend_entry.first.c_str(), description.c_str()); 234 legend_entry.first.c_str(), description.c_str());
235 // Highlight some exceptionable conditions. 235 // Highlight some exceptionable conditions.
236 if (site_instance->active_frame_count() == 0) 236 if (site_instance->active_frame_count() == 0)
237 result.append(" (active_frame_count == 0)"); 237 result.append(" (active_frame_count == 0)");
238 if (!site_instance->GetProcess()->HasConnection()) 238 if (!site_instance->GetProcess()->HasConnection())
239 result.append(" (no process)"); 239 result.append(" (no process)");
240 prefix = " "; 240 prefix = " ";
241 } 241 }
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
391 NavigationHandle* navigation_handle) { 391 NavigationHandle* navigation_handle) {
392 if (navigation_handle->HasCommitted() && 392 if (navigation_handle->HasCommitted() &&
393 !navigation_handle->IsErrorPage() && 393 !navigation_handle->IsErrorPage() &&
394 navigation_handle->GetURL() == url_ && 394 navigation_handle->GetURL() == url_ &&
395 navigation_handle->GetFrameTreeNodeId() == frame_tree_node_id_) { 395 navigation_handle->GetFrameTreeNodeId() == frame_tree_node_id_) {
396 message_loop_runner_->Quit(); 396 message_loop_runner_->Quit();
397 } 397 }
398 } 398 }
399 399
400 } // namespace content 400 } // namespace content
OLDNEW
« no previous file with comments | « content/public/browser/site_instance.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698