Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2437243002: Fix an issue that opening a download with remapped MIME type will launch an intent (Closed)

Created:
4 years, 2 months ago by qinmin
Modified:
4 years, 1 month ago
Reviewers:
gone
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix an issue that opening a download with remapped MIME type will launch an intent When a download's MIME type is remapped, Chrome should use the new MIME type. However, when opening a download from download home, GUID is used to find the download. The download history stores the original MIME type, which is not remapped. This causes Chrome to incorrectly launch an intent even if the type is supported. BUG=657594 Committed: https://crrev.com/1ff89f652baf6e0397c946d76371a04fdda754a0 Cr-Commit-Position: refs/heads/master@{#427205}

Patch Set 1 #

Messages

Total messages: 12 (5 generated)
qinmin
PTAL
4 years, 2 months ago (2016-10-20 22:40:56 UTC) #2
gone
lgtm
4 years, 1 month ago (2016-10-24 17:30:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437243002/1
4 years, 1 month ago (2016-10-24 17:34:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/151433)
4 years, 1 month ago (2016-10-24 21:04:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437243002/1
4 years, 1 month ago (2016-10-24 22:08:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 01:10:11 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 01:13:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ff89f652baf6e0397c946d76371a04fdda754a0
Cr-Commit-Position: refs/heads/master@{#427205}

Powered by Google App Engine
This is Rietveld 408576698