BrowserProcessImpl: don't call IsIsolateExtensionsEnabled() too early

BrowserProcessImpl: don't call IsIsolateExtensionsEnabled() too early

This fixes a bug where IsIsolateExtensionsEnabled() had been called prior to the
field trials actually being initialized, so the call returned true regardless
of the finch experiment state, resulting in a possible misconfiguration of
security state.

PreCreateThreads() seems to be the earliest place in BrowserProcessImpl where we
can do this registration.

BUG=657629
NOTRY=true
NOPRESUBMIT=true
TBR=creis@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2438823003
Cr-Commit-Position: refs/heads/master@{#426852}
(cherry picked from commit a0b7b87ea093cbb45f51c4ab1465b4e4115a5d99)

[ncarter (slow), 2016-10-24 20:04:15]

The CQ bit was checked by nick@chromium.org

[ncarter (slow), 2016-10-24 20:04:45]

Description was changed from

==========
BrowserProcessImpl: don't call IsIsolateExtensionsEnabled() too early

This fixes a bug where IsIsolateExtensionsEnabled() had been called prior to the
field trials actually being initialized, so the call returned true regardless
of the finch experiment state, resulting in a possible misconfiguration of
security state.

PreCreateThreads() seems to be the earliest place in BrowserProcessImpl where we
can do this registration.

BUG=657629

Review-Url: https://chromiumcodereview.appspot.com/2438823003
Cr-Commit-Position: refs/heads/master@{#426852}
(cherry picked from commit a0b7b87ea093cbb45f51c4ab1465b4e4115a5d99)
==========

to

==========
BrowserProcessImpl: don't call IsIsolateExtensionsEnabled() too early

This fixes a bug where IsIsolateExtensionsEnabled() had been called prior to the
field trials actually being initialized, so the call returned true regardless
of the finch experiment state, resulting in a possible misconfiguration of
security state.

PreCreateThreads() seems to be the earliest place in BrowserProcessImpl where we
can do this registration.

BUG=657629
NOTRY=true
NOPRESUBMIT=true
TBR=creis@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2438823003
Cr-Commit-Position: refs/heads/master@{#426852}
(cherry picked from commit a0b7b87ea093cbb45f51c4ab1465b4e4115a5d99)
==========

[commit-bot: I haz the power, 2016-10-24 20:05:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 20:08:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 20:08:33]

Failed to commit the patch.

[ncarter (slow), 2016-10-24 20:09:49]

The CQ bit was checked by nick@chromium.org

[commit-bot: I haz the power, 2016-10-24 20:10:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 20:13:26]

Description was changed from

==========
BrowserProcessImpl: don't call IsIsolateExtensionsEnabled() too early

This fixes a bug where IsIsolateExtensionsEnabled() had been called prior to the
field trials actually being initialized, so the call returned true regardless
of the finch experiment state, resulting in a possible misconfiguration of
security state.

PreCreateThreads() seems to be the earliest place in BrowserProcessImpl where we
can do this registration.

BUG=657629
NOTRY=true
NOPRESUBMIT=true
TBR=creis@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2438823003
Cr-Commit-Position: refs/heads/master@{#426852}
(cherry picked from commit a0b7b87ea093cbb45f51c4ab1465b4e4115a5d99)
==========

to

==========
BrowserProcessImpl: don't call IsIsolateExtensionsEnabled() too early

This fixes a bug where IsIsolateExtensionsEnabled() had been called prior to the
field trials actually being initialized, so the call returned true regardless
of the finch experiment state, resulting in a possible misconfiguration of
security state.

PreCreateThreads() seems to be the earliest place in BrowserProcessImpl where we
can do this registration.

BUG=657629
NOTRY=true
NOPRESUBMIT=true
TBR=creis@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2438823003
Cr-Commit-Position: refs/heads/master@{#426852}
(cherry picked from commit a0b7b87ea093cbb45f51c4ab1465b4e4115a5d99)
==========

[commit-bot: I haz the power, 2016-10-24 20:13:27]

Committed patchset #1 (id:1)