Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2437193002: Log to UMA why we would load a third-party frame (Closed)

Created:
4 years, 2 months ago by dgrogan
Modified:
4 years, 2 months ago
Reviewers:
Ilya Sherman, dcheng
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, asvitkine+watch_chromium.org, blink-reviews, kinuko+watch, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Log to UMA why we would load a third-party frame This will give an estimate of the % of iframes that we can defer loading. We can defer offscreen frames unless they are probably used for cross-origin communication. Reland of https://codereview.chromium.org/2389023002 BUG=635105 TBR=isherman@chromium.org Committed: https://crrev.com/c301da12f702e16e64faf04524f89bde02ad9588 Cr-Commit-Position: refs/heads/master@{#426979}

Patch Set 1 : old patch that got reverted #

Patch Set 2 : don't copy SimRequest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -30 lines) Patch
M third_party/WebKit/Source/core/dom/Document.h View 3 chunks +26 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 4 chunks +12 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 3 chunks +20 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/web/tests/DeferredLoadingTest.cpp View 1 1 chunk +187 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
dgrogan
Looks like I shouldn't have been copying stack-allocated SimRequest objects. Do you know why this ...
4 years, 2 months ago (2016-10-21 17:21:59 UTC) #3
dcheng
On 2016/10/21 17:21:59, dgrogan wrote: > Looks like I shouldn't have been copying stack-allocated SimRequest ...
4 years, 2 months ago (2016-10-21 17:23:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437193002/20001
4 years, 2 months ago (2016-10-21 17:24:08 UTC) #6
dgrogan
TBR=isherman because it's a reland, histograms are identical to the previously-approved patch
4 years, 2 months ago (2016-10-21 17:35:59 UTC) #9
dcheng
On 2016/10/21 17:35:59, dgrogan wrote: > TBR=isherman because it's a reland, histograms are identical to ...
4 years, 2 months ago (2016-10-21 17:41:02 UTC) #10
dgrogan
This is the stack trace: blink::KURL::operator= [0x076823E1+17] blink::ResourceResponse::operator= [0x075A3823+19] blink::WebURLResponse::operator= [0x072C6063+339] blink::SimRequest::didReceiveResponse [0x008EBB89+41] blink::SimNetwork::didReceiveResponse [0x008EA717+343] ...
4 years, 2 months ago (2016-10-21 17:45:47 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/321609)
4 years, 2 months ago (2016-10-21 21:26:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437193002/20001
4 years, 2 months ago (2016-10-21 21:27:35 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/321694)
4 years, 2 months ago (2016-10-22 01:39:35 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437193002/20001
4 years, 2 months ago (2016-10-22 01:45:36 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-22 05:22:05 UTC) #21
commit-bot: I haz the power
4 years, 2 months ago (2016-10-22 06:12:20 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c301da12f702e16e64faf04524f89bde02ad9588
Cr-Commit-Position: refs/heads/master@{#426979}

Powered by Google App Engine
This is Rietveld 408576698