content/test/data/navigation_controller/inject_iframe_srcdoc_with_nested_frame.html - Issue 2437173002: Fix going back to a script-injected about:blank frame.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/navigation_controller/inject_iframe_srcdoc_with_nested_frame.html

Issue 2437173002: Fix going back to a script-injected about:blank frame. (Closed)

Patch Set: Disable srcdoc test in PlzNavigate Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <html>

	2 <head></head>

	3 <body>

	4 <p>This page injects an inner frame into an injected blank iframe.
	alexmos 2016/10/21 06:34:16 nit: s/blank/srcdoc/? Also, the page really injec nit: s/blank/srcdoc/? Also, the page really injects just the srcdoc frame, not the inner frame. Charlie Reis 2016/10/21 07:34:30 Done. Show quoted text On 2016/10/21 06:34:16, alexmos wrote: > nit: s/blank/srcdoc/? Also, the page really injects just the srcdoc frame, not > the inner frame. Done.
	5 <div id="myDiv"></div>

	6 <script>

	7 var iframeHtml =

	8 '<iframe srcdoc="<iframe src=\'form.html\' id=\'outer\'>' +
	alexmos 2016/10/21 06:34:16 nit: remove "outer", as it's unused here? Or rena nit: remove "outer", as it's unused here? Or rename to "inner" :) Charlie Reis 2016/10/21 07:34:30 Done. Show quoted text On 2016/10/21 06:34:16, alexmos wrote: > nit: remove "outer", as it's unused here? Or rename to "inner" :) Done.
	9 '<\/iframe>"><\/iframe>';

	10

	11 // Create an iframe srcdoc with nested frame inside the preexisting div.

	12 document.getElementById('myDiv').innerHTML = iframeHtml;

	13 </script>

	14 </body>

	15 </html>

OLD	NEW