Issue 2437103003: Do not try to pop up the account chooser if there is no browser window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2437103003: Do not try to pop up the account chooser if there is no browser window. (Closed)

Created:
4 years, 2 months ago by vasilii

Modified:
4 years, 2 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

Do not try to pop up the account chooser if there is no browser window. The situation was happening during prefetch. BUG=656406 Review-Url: https://chromiumcodereview.appspot.com/2432483002 Cr-Commit-Position: refs/heads/master@{#426144} (cherry picked from commit 4fa5f3285b050cb2823b41320777cb52f64c9508) Committed: https://chromium.googlesource.com/chromium/src/+/aaed728b18b11edf85c59ab00d3ef0220de06215

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -0 lines)			Patch
M	chrome/browser/ui/passwords/manage_passwords_ui_controller.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/passwords/manage_passwords_ui_controller.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc	View	5 chunks	+20 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

vasilii

4 years, 2 months ago (2016-10-21 09:01:02 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
aaed728b18b11edf85c59ab00d3ef0220de06215.