Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Issue 2437103002: [turbofan] Remove deprecated --turbo-from-bytecode flag. (Closed)

Created:
4 years, 2 months ago by Michael Starzinger
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove deprecated --turbo-from-bytecode flag. This flag is on by default for now. Whenever heuristics in the compiler pipeline decide to use Ignition+TurboFan, then {BytecodeGraphBuilder} is active. Removing the flag reduces maintenance overhead. R=mvstanton@chromium.org Committed: https://crrev.com/ae2499283980f6d1388fb1991263d3f9e75b116c Cr-Commit-Position: refs/heads/master@{#40639}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -698 lines) Patch
M src/ast/ast-numbering.cc View 1 chunk +1 line, -6 lines 0 comments Download
M src/compiler.cc View 1 5 chunks +8 lines, -15 lines 0 comments Download
M src/flag-definitions.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/array-literal-transitions.js View 1 chunk +1 line, -2 lines 0 comments Download
D test/mjsunit/harmony/generators-turbo.js View 1 chunk +0 lines, -667 lines 0 comments Download
M test/mjsunit/ignition/osr-from-bytecode.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-2618.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-5252.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-5262.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-632289.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-632800.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-635923.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (14 generated)
Michael Starzinger
We don't need no off-switch where we are going. :)
4 years, 2 months ago (2016-10-20 15:36:09 UTC) #3
mvstanton
No. We. ( LGTM ! ) Don't.
4 years, 2 months ago (2016-10-20 21:23:50 UTC) #6
Michael Hablich
On 2016/10/20 21:23:50, mvstanton wrote: > No. > We. ( LGTM ! ) > Don't. ...
4 years, 2 months ago (2016-10-21 08:04:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437103002/20001
4 years, 1 month ago (2016-10-28 09:51:44 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-28 09:53:46 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:16:29 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ae2499283980f6d1388fb1991263d3f9e75b116c
Cr-Commit-Position: refs/heads/master@{#40639}

Powered by Google App Engine
This is Rietveld 408576698