[compiler] Mark shared functions for optimization

src/compiler.cc

Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index 1b623c2b477029d86098ffc28d4a08a95dab06f9..130e977ead3eab816b718a708394f84fcdc925fc 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -977,6 +977,20 @@ MaybeHandle<Code> GetLazyCode(Handle<JSFunction> function) {
     return cached_code;
   }
 
+  if (function->shared()->was_marked_for_optimization()) {

[Michael Starzinger, 2016/10/21 11:37:58]

The flag never seems to be cleared. This will mark all instances hot for all
eternity even if we deoptimized multiple times and disabled optimization. I
think we should just clear the flag here eagerly. As soon as at least one
instance within a native context has been optimized, the optimized code map
should contain an entry and the lazy compile stub will pick it up. WDYT?

[Leszek Swirski, 2016/10/21 11:44:13]

That's a very good point, I hadn't considered optimization getting disabled.
Clearing the flag seems like a reasonable thing to do, so done.

+    if (FLAG_trace_opt) {
+      PrintF("[optimizing function ");
+      function->PrintName();
+      PrintF(" eagerly because shared function was previously marked]\n");
+    }
+
+    Handle<Code> opt_code;
+    if (GetOptimizedCode(function, Compiler::NOT_CONCURRENT)
+            .ToHandle(&opt_code)) {
+      return opt_code;
+    }
+  }
+
   if (function->shared()->is_compiled()) {
     return Handle<Code>(function->shared()->code());
   }