Linux Aura: Use appropriate button style depending on aura/gtk NativeTheme

Linux Aura: Use appropriate button style depending on aura/gtk NativeTheme

BUG=347832
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266097

[sky, 2014-04-21 20:01:11]

LGTM

[Elliot Glaysher, 2014-04-21 22:48:50]

lgtm

You also should be able to do some simplification in
Gtk2Border::GetMinimumSize() and maybe in Gtk2Border::GetInsets(). Please check
to make sure that in gtk mode, the system back/forward/reload icon assets aren't
clipped.

[Evan Stade, 2014-04-22 22:03:20]

On 2014/04/21 22:48:50, Elliot Glaysher wrote:
> lgtm
> 
> You also should be able to do some simplification in
> Gtk2Border::GetMinimumSize() and maybe in Gtk2Border::GetInsets(). Please
check
> to make sure that in gtk mode, the system back/forward/reload icon assets
aren't
> clipped.

Removed the extra code (thought it might still be necessary for some reason).
The back/forward/reload assets are all ok on the ~10 icon themes I tried. Is
there some particularly problematic icon theme I should be testing against?

[Elliot Glaysher, 2014-04-22 22:14:02]

No, afaik, it's most themes, including the default theme. The tips of the arrows
get cut. If you don't see any clipping, then you should be good.

[Evan Stade, 2014-04-24 17:16:55]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-04-24 17:17:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/243703009/80001

[commit-bot: I haz the power, 2014-04-24 22:39:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 22:39:48]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[Evan Stade, 2014-04-25 00:26:01]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-04-25 00:27:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/243703009/80001

[commit-bot: I haz the power, 2014-04-25 02:45:12]

Change committed as 266097