LayoutTests/push_messaging/push-messaging.html - Issue 243703007: Enable V8 Promises.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/push_messaging/push-messaging.html

Issue 243703007: Enable V8 Promises. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove v8::Isolate::InContext branch Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: LayoutTests/push_messaging/push-messaging.html

diff --git a/LayoutTests/push_messaging/push-messaging.html b/LayoutTests/push_messaging/push-messaging.html

index c8c4343721124d8e58da1a10990a2cac1321764b..e9f06200936b6917902d607f903ea7d03aa65b2d 100644

--- a/LayoutTests/push_messaging/push-messaging.html

+++ b/LayoutTests/push_messaging/push-messaging.html

@@ -14,7 +14,7 @@ window.jsTestIsAsync = true;

shouldBeTrue('!!navigator.push');

shouldBeTrue('!!navigator.push.register');

-shouldBeEqualToString('String(navigator.push.register("senderId"))', '[object Promise]');

+shouldBe('navigator.push.register("senderId").constructor', 'Promise');

// Currently we have an empty implementation that always fails.

navigator.push.register('senderId').then(function successCallback() {