Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 243703004: Revert "Remove notifications from PrintPreviewDialogController." (Closed)

Created:
6 years, 8 months ago by Avi (use Gerrit)
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert "Remove notifications from PrintPreviewDialogController." This essentially reverts r243252. BUG=170921, 359627 TEST=as in bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264917

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -168 lines) Patch
M chrome/browser/printing/print_preview_dialog_controller.h View 5 chunks +36 lines, -9 lines 0 comments Download
M chrome/browser/printing/print_preview_dialog_controller.cc View 11 chunks +112 lines, -159 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Avi (use Gerrit)
I would like to not do this, but I'm stumped and we need to get ...
6 years, 8 months ago (2014-04-18 22:23:59 UTC) #1
Lei Zhang
lgtm, and sad trombone.
6 years, 8 months ago (2014-04-18 22:28:03 UTC) #2
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 8 months ago (2014-04-18 22:30:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/243703004/1
6 years, 8 months ago (2014-04-18 22:30:23 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-18 23:04:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg
6 years, 8 months ago (2014-04-18 23:04:50 UTC) #6
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 8 months ago (2014-04-18 23:15:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/243703004/1
6 years, 8 months ago (2014-04-18 23:15:48 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-19 01:10:13 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-19 01:10:14 UTC) #10
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 8 months ago (2014-04-19 01:11:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/243703004/1
6 years, 8 months ago (2014-04-19 01:12:14 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-19 03:27:32 UTC) #13
Message was sent while issue was closed.
Change committed as 264917

Powered by Google App Engine
This is Rietveld 408576698