Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js

Issue 2436953003: [Devtools] Highlight navigation request in network timeline exp (Closed)
Patch Set: [Devtools] Highlight navigation request in network timeline exp Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
index a8d1575806d4fb6de54ce62bc3865923b6e61cbd..c14638ae9495f97c4083631b6345d3634edd4022 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
@@ -57,8 +57,13 @@ WebInspector.NetworkTimelineColumn = function(rowHeight, headerHeight, calculato
/** @type {?WebInspector.NetworkRequest} */
this._hoveredRequest = null;
- this._rowStripeColor = WebInspector.themeSupport.patchColor("#f5f5f5", WebInspector.ThemeSupport.ColorUsage.Background);
- this._rowHoverColor = WebInspector.themeSupport.patchColor("#ebf2fc", WebInspector.ThemeSupport.ColorUsage.Background);
+ /** @type {?WebInspector.NetworkRequest} */
+ this._navigationRequest = null;
+
+ var colorUsage = WebInspector.ThemeSupport.ColorUsage;
+ this._rowNavigationRequestColor = WebInspector.themeSupport.patchColor("#def", colorUsage.Background);
+ this._rowStripeColor = WebInspector.themeSupport.patchColor("#f5f5f5", colorUsage.Background);
+ this._rowHoverColor = WebInspector.themeSupport.patchColor("#ebf2fc", /** @type {!WebInspector.ThemeSupport.ColorUsage} */ (colorUsage.Background | colorUsage.Selection));
allada 2016/10/20 23:30:43 I found this bug and figured to change it here whi
/** @type {!Map<!WebInspector.ResourceType, string>} */
this._borderColorsForResourceTypeCache = new Map();
@@ -151,9 +156,11 @@ WebInspector.NetworkTimelineColumn.prototype = {
/**
* @param {!Array<!WebInspector.NetworkRequest>} requests
+ * @param {?WebInspector.NetworkRequest} navigationRequest
*/
- setRequests: function(requests)
+ setRequests: function(requests, navigationRequest)
{
+ this._navigationRequest = navigationRequest;
this._requestData = requests;
},
@@ -613,13 +620,15 @@ WebInspector.NetworkTimelineColumn.prototype = {
*/
_decorateRow: function(context, request, rowNumber, y)
{
- if (rowNumber % 2 === 1 && this._hoveredRequest !== request)
+ if (rowNumber % 2 === 1 && this._hoveredRequest !== request && this._navigationRequest !== request)
return;
context.save();
context.beginPath();
var color = this._rowStripeColor;
if (this._hoveredRequest === request)
color = this._rowHoverColor;
+ else if (this._navigationRequest === request)
+ color = this._rowNavigationRequestColor;
context.fillStyle = color;
context.rect(0, y, this._offsetWidth, this._rowHeight);
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698