[Devtools] Highlight navigation request in network timeline exp

third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 311 matching lines @@
         function requestHovered(event)
         {
             var request = /** @type {?WebInspector.NetworkRequest} */ (event.data);
             var node = request ? this._nodesByRequestId.get(request.requestId) : null;
             this._setHoveredNode(node || null);
         }
     },
 
     _redrawTimelineColumn: function()
     {
-        /** @type {!Array<!WebInspector.NetworkRequest>|undefined} */
-        var requests;
-        if (this._timelineRequestsAreStale)
-            requests = this._getOrderedRequests();
-        this._timelineColumn.update(requests);
+        if (!this._timelineRequestsAreStale) {
+            this._timelineColumn.draw();

[dgozman, 2016/10/21 20:39:21]

There is no |draw| method.

[allada, 2016/10/21 22:22:26]

Done.

+            return;
+        }
+        var currentNode = this._dataGrid.rootNode();
+        var requestData = [];
+        var navigationRequest = null;

[dgozman, 2016/10/21 20:39:21]

|update| doesn't accept null as a second argument. How does this compile?

[allada, 2016/10/21 22:22:26]

Done.

+        while (currentNode = currentNode.traverseNextNode(true)) {
+            if (currentNode.isNavigationRequest())
+                navigationRequest = currentNode.request();
+            requestData.push(currentNode.request());
+        }
+        this._timelineColumn.update(requestData, navigationRequest);
     },
 
     _showRecordingHint: function()
     {
         this._hideRecordingHint();
         this._recordingHint = this.element.createChild("div", "network-status-pane fill");
         var hintText = this._recordingHint.createChild("div", "recording-hint");
         var reloadShortcutNode = this._recordingHint.createChild("b");
         reloadShortcutNode.textContent = WebInspector.shortcutRegistry.shortcutDescriptorsForAction("main.reload")[0].name;
 
@@ skipping 377 matching lines @@
                 nodes[i].refreshGraph();
         }
 
         this._staleRequestIds = {};
         this._updateSummaryBar();
 
         if (Runtime.experiments.isEnabled("canvasNetworkTimeline"))
             this._timelineRequestsAreStale = true;
     },
 
-    _getOrderedRequests: function()
-    {
-        var currentNode = this._dataGrid.rootNode();
-        var requestData = [];
-        while (currentNode = currentNode.traverseNextNode(true))
-            requestData.push(currentNode.request());
-        return requestData;
-    },
-
     reset: function()
     {
         this._requestWithHighlightedInitiators = null;
         this.dispatchEventToListeners(WebInspector.NetworkLogView.Events.RequestSelected, null);
 
         this._clearSearchMatchedList();
 
         this._columns.reset();
 
         this._hoveredNode = null;
@@ skipping 1141 matching lines @@
  * @return {boolean}
  */
 WebInspector.NetworkLogView._requestTimeFilter = function(windowStart, windowEnd, request)
 {
     if (request.issueTime() > windowEnd)
         return false;
     if (request.endTime !== -1 && request.endTime < windowStart)
         return false;
     return true;
 }