Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1615)

Unified Diff: chrome/browser/chromeos/arc/arc_auth_service.h

Issue 2436903003: Extract ArcSupportMessageHost. (Closed)
Patch Set: Address comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/arc/arc_auth_service.h
diff --git a/chrome/browser/chromeos/arc/arc_auth_service.h b/chrome/browser/chromeos/arc/arc_auth_service.h
index 8f161ed6a8bd73e4bcbbd25bed609c36ca49f576..34e63d9f74eb422d52602d5799f7eed7fd1ebd09 100644
--- a/chrome/browser/chromeos/arc/arc_auth_service.h
+++ b/chrome/browser/chromeos/arc/arc_auth_service.h
@@ -36,6 +36,8 @@ namespace user_prefs {
class PrefRegistrySyncable;
}
+class ArcSupportHost;
+
namespace arc {
class ArcAndroidManagementChecker;
@@ -80,12 +82,6 @@ class ArcAuthService : public ArcService,
// Called whenever Opt-In state of the ARC has been changed.
virtual void OnOptInChanged(State state) {}
- // Called to notify that OptIn UI needs to be closed.
- virtual void OnOptInUIClose() {}
-
- // Called to notify that OptIn UI needs to show specific page.
- virtual void OnOptInUIShowPage(UIPage page, const base::string16& status) {}
-
// Called to notify that ARC bridge is shut down.
virtual void OnShutdownBridge() {}
@@ -207,8 +203,11 @@ class ArcAuthService : public ArcService,
// Returns current page status, relevant to the specific page.
const base::string16& ui_page_status() const { return ui_page_status_; }
+ ArcSupportHost* support_host() { return support_host_.get(); }
+
private:
void StartArc();
+ // TODO: move UI methods/fields to ArcSupportHost.
void ShowUI(UIPage page, const base::string16& status);
void CloseUI();
void SetUIPage(UIPage page, const base::string16& status);
@@ -248,6 +247,11 @@ class ArcAuthService : public ArcService,
bool reenable_arc_ = false;
base::OneShotTimer arc_sign_in_timer_;
+ // Temporarily keeps the ArcSupportHost instance.
+ // This should be moved to ArcSessionManager when the refactoring is
+ // done.
+ std::unique_ptr<ArcSupportHost> support_host_;
+
std::unique_ptr<ArcAuthContext> context_;
std::unique_ptr<ArcAuthCodeFetcher> auth_code_fetcher_;
std::unique_ptr<ArcAndroidManagementChecker> android_management_checker_;

Powered by Google App Engine
This is Rietveld 408576698