Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2436903002: Removed uses of IsRunningOnIOS9OrLater in crw_web_ or wk_web_view_ (Closed)

Created:
4 years, 2 months ago by pkl (ping after 24h if needed)
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed uses of IsRunningOnIOS9OrLater in crw_web_ or wk_web_view_ BUG=633626 Committed: https://crrev.com/cf7070deba73f5befc29c214b1b44779f7c81358 Cr-Commit-Position: refs/heads/master@{#427108}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -16 lines) Patch
M ios/web/test/wk_web_view_crash_utils.mm View 2 chunks +3 lines, -6 lines 0 comments Download
M ios/web/web_state/crw_web_view_proxy_impl.mm View 2 chunks +0 lines, -5 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +2 lines, -3 lines 0 comments Download
M ios/web/web_state/ui/wk_web_view_configuration_provider.mm View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
pkl (ping after 24h if needed)
4 years, 2 months ago (2016-10-19 22:53:37 UTC) #2
Eugene But (OOO till 7-30)
lgtm
4 years, 1 month ago (2016-10-24 16:09:26 UTC) #3
Eugene But (OOO till 7-30)
Thanks for cleanup!
4 years, 1 month ago (2016-10-24 16:09:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2436903002/1
4 years, 1 month ago (2016-10-24 18:07:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 18:55:17 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 19:23:38 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf7070deba73f5befc29c214b1b44779f7c81358
Cr-Commit-Position: refs/heads/master@{#427108}

Powered by Google App Engine
This is Rietveld 408576698