Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2436863004: Add new chromium recipe builder to chromium.perf (Closed)

Created:
4 years, 2 months ago by martiniss
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Change name. #

Patch Set 3 : Remove old file. #

Total comments: 1

Patch Set 4 : Fix names #

Patch Set 5 : Fix expectation name. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -39 lines) Patch
M masters/master.chromium.perf/master.cfg View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M masters/master.chromium.perf/slaves.cfg View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_perf.py View 1 2 3 2 chunks +8 lines, -2 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Compile.json View 1 2 3 4 12 chunks +40 lines, -37 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
martiniss
PTAL Adding a chromium recipe builder to trigger a bot I'll switch over to the ...
4 years, 2 months ago (2016-10-20 16:47:48 UTC) #2
sullivan
lgtm https://codereview.chromium.org/2436863004/diff/40001/masters/master.chromium.perf/slaves.cfg File masters/master.chromium.perf/slaves.cfg (right): https://codereview.chromium.org/2436863004/diff/40001/masters/master.chromium.perf/slaves.cfg#newcode40 masters/master.chromium.perf/slaves.cfg:40: 'Android Temporary Compile', 'linux', 'trusty', ['slaveXXX-c1']) Why Android ...
4 years, 2 months ago (2016-10-20 19:56:12 UTC) #3
martiniss
Fixed. Need chromium tests owner.
4 years, 1 month ago (2016-10-25 21:01:09 UTC) #5
martiniss
On 2016/10/25 at 21:01:09, martiniss wrote: > Fixed. (It was Temporary Compile before, but then ...
4 years, 1 month ago (2016-10-25 21:01:29 UTC) #6
dtu
lgtm!
4 years, 1 month ago (2016-10-25 21:38:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2436863004/60001
4 years, 1 month ago (2016-10-25 21:40:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2436863004/80001
4 years, 1 month ago (2016-10-25 21:46:36 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 21:56:11 UTC) #16
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/tools/build/+/95e18e5e456fcba0dbc6...

Powered by Google App Engine
This is Rietveld 408576698