Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2436753002: Removed ONC check in ArcSettingsService. (Closed)

Created:
4 years, 2 months ago by Polina Bondarenko
Modified:
4 years, 1 month ago
Reviewers:
stevenjb
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed ONC check in ArcSettingsService. Removed ONC proxy policy applied check when the default network is changed. If proxy settings are bundled to the specific network and another network is connected on startup, these settings are not transferred to ARC on startup and should be transferred only when the network becomes a default netowork. BUG=657361 TEST=browsertest Committed: https://crrev.com/c30dd018f081d567e5fd53f45a733d8be5c00b01 Cr-Commit-Position: refs/heads/master@{#427058}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -20 lines) Patch
M chrome/browser/chromeos/arc/arc_settings_service.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_settings_service_browsertest.cc View 7 chunks +180 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Polina Bondarenko
Hi Steven, PTAL Removed ONC policy check and added a browser test, that was failing ...
4 years, 2 months ago (2016-10-19 12:17:25 UTC) #2
stevenjb
lgtm
4 years, 2 months ago (2016-10-21 20:18:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2436753002/1
4 years, 1 month ago (2016-10-24 13:28:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 13:41:56 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 13:43:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c30dd018f081d567e5fd53f45a733d8be5c00b01
Cr-Commit-Position: refs/heads/master@{#427058}

Powered by Google App Engine
This is Rietveld 408576698