Fix DeclarationResolver handling of annotations containing closures.

pkg/analyzer/lib/src/generated/declaration_resolver.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.generated.declaration_resolver;
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/token.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/exception/exception.dart';
+import 'package:analyzer/src/dart/element/builder.dart';
 import 'package:analyzer/src/dart/element/element.dart';
+import 'package:analyzer/src/generated/resolver.dart';
 
 /**
  * A visitor that resolves declarations in an AST structure to already built
  * elements.
  *
  * The resulting AST must have everything resolved that would have been resolved
  * by a [CompilationUnitBuilder] (that is, must be a valid [RESOLVED_UNIT1]).
  * This class must not assume that the [CompilationUnitElement] passed to it is
  * any more complete than a [COMPILATION_UNIT_ELEMENT].
  */
@@ skipping 21 matching lines @@
     try {
       unit.accept(this);
       _walker.validate();
     } on Error catch (e, st) {
       throw new _ElementMismatchException(
           element, _walker.element, new CaughtException(e, st));
     }
   }
 
   @override
+  Object visitAnnotation(Annotation node) {
+    // Annotations can only contain elements in certain erroneous situations,
+    // in which case the elements are disconnected from the rest of the element
+    // model, thus we can't reconnect to them.  To avoid crashes, just create
+    // fresh elements.
+    ElementHolder elementHolder = new ElementHolder();
+    new ElementBuilder(elementHolder, _enclosingUnit).visitAnnotation(node);
+    return null;
+  }
+
+  @override
   Object visitCatchClause(CatchClause node) {
     SimpleIdentifier exceptionParameter = node.exceptionParameter;
     if (exceptionParameter != null) {
       _match(exceptionParameter, _walker.getVariable());
       SimpleIdentifier stackTraceParameter = node.stackTraceParameter;
       if (stackTraceParameter != null) {
         _match(stackTraceParameter, _walker.getVariable());
       }
     }
     return super.visitCatchClause(node);
@@ skipping 555 matching lines @@
 class _ElementMismatchException extends AnalysisException {
   /**
    * Creates an exception to refer to the given [compilationUnit], [element],
    * and [cause].
    */
   _ElementMismatchException(
       CompilationUnitElement compilationUnit, Element element,
       [CaughtException cause = null])
       : super('Element mismatch in $compilationUnit at $element', cause);
 }