Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Unified Diff: third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js

Issue 2436703003: DevTools: Flesh out AccessibilityModel and use SDK objects instead of protocol objects (Closed)
Patch Set: revert accessibilityNode.css Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js b/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
index 59f69b4810f4b7876707caa5d1ec23027f8742de..309f4876cd16cf85a8112fefbda4a0f35bc9bbf5 100644
--- a/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
+++ b/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
@@ -10,6 +10,7 @@ WebInspector.AccessibilitySidebarView = function()
{
WebInspector.ThrottledWidget.call(this);
this._node = null;
+ this._axNode = null;
this._sidebarPaneStack = WebInspector.viewManager.createStackLocation();
this._treeSubPane = new WebInspector.AXTreePane();
this._sidebarPaneStack.showView(this._treeSubPane);
@@ -32,7 +33,7 @@ WebInspector.AccessibilitySidebarView.prototype = {
},
/**
- * @param {?Array<!AccessibilityAgent.AXNode>} nodes
+ * @param {?Array<!WebInspector.AccessibilityNode>} nodes
*/
accessibilityNodeCallback: function(nodes)
{
@@ -62,7 +63,7 @@ WebInspector.AccessibilitySidebarView.prototype = {
this._treeSubPane.setNode(node);
this._axNodeSubPane.setNode(node);
this._ariaSubPane.setNode(node);
- return WebInspector.AccessibilityModel.fromTarget(node.target()).getAXNodeChain(node.id)
+ return WebInspector.AccessibilityModel.fromTarget(node.target()).getAXNodeChain(node)
.then((nodes) => { this.accessibilityNodeCallback(nodes); });
},
@@ -97,8 +98,6 @@ WebInspector.AccessibilitySidebarView.prototype = {
_pullNode: function()
{
this._node = WebInspector.context.flavor(WebInspector.DOMNode);
- this._ariaSubPane.setNode(this._node);
- this._axNodeSubPane.setNode(this._node);
this.update();
},
@@ -147,7 +146,7 @@ WebInspector.AccessibilitySubPane = function(name)
WebInspector.AccessibilitySubPane.prototype = {
/**
- * @param {?AccessibilityAgent.AXNode} axNode
+ * @param {?WebInspector.AccessibilityNode} axNode
* @protected
*/
setAXNode: function(axNode)

Powered by Google App Engine
This is Rietveld 408576698