Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 243663003: Make all Cast related whitelists consistent. (Closed)

Created:
6 years, 8 months ago by mark a. foltz
Modified:
6 years, 8 months ago
Reviewers:
miket_OOO, tbarzic
CC:
not at google - send to devlin, Alpha Left Google, markdavidscott, haibinlu, chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Make all Cast related whitelists consistent: - remove unused entry - use consistent labels - use hashes for all whitelists TESTED=Installed all Cast extensions and made sure there were no permissions errors. BUG=345846 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265126

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix ids in _api_features.json #

Patch Set 3 : Replace ids with hashes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -32 lines) Patch
M chrome/common/extensions/api/_api_features.json View 2 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 2 6 chunks +23 lines, -26 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mark a. foltz
6 years, 8 months ago (2014-04-18 21:32:19 UTC) #1
not at google - send to devlin
https://codereview.chromium.org/243663003/diff/1/chrome/common/extensions/api/_permission_features.json File chrome/common/extensions/api/_permission_features.json (right): https://codereview.chromium.org/243663003/diff/1/chrome/common/extensions/api/_permission_features.json#newcode170 chrome/common/extensions/api/_permission_features.json:170: "boadgeojelhgndaghljhdicfkmllpafd" // Google Cast Stable we are trying to ...
6 years, 8 months ago (2014-04-18 21:35:36 UTC) #2
mark a. foltz
On 2014/04/18 21:35:36, kalman wrote: > https://codereview.chromium.org/243663003/diff/1/chrome/common/extensions/api/_permission_features.json > File chrome/common/extensions/api/_permission_features.json (right): > > https://codereview.chromium.org/243663003/diff/1/chrome/common/extensions/api/_permission_features.json#newcode170 > ...
6 years, 8 months ago (2014-04-18 21:39:35 UTC) #3
not at google - send to devlin
hm. wiki out of date I guess. +miket who owns this.
6 years, 8 months ago (2014-04-18 21:40:21 UTC) #4
mark a. foltz
On 2014/04/18 21:40:21, kalman wrote: > hm. wiki out of date I guess. +miket who ...
6 years, 8 months ago (2014-04-18 21:52:11 UTC) #5
miket_OOO
On 2014/04/18 21:52:11, mark a. foltz wrote: > On 2014/04/18 21:40:21, kalman wrote: > > ...
6 years, 8 months ago (2014-04-18 22:35:42 UTC) #6
tbarzic
lgtm
6 years, 8 months ago (2014-04-21 22:26:36 UTC) #7
mark a. foltz
The CQ bit was checked by mfoltz@chromium.org
6 years, 8 months ago (2014-04-21 22:36:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mfoltz@chromium.org/243663003/40001
6 years, 8 months ago (2014-04-21 22:37:15 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 00:36:33 UTC) #10
Message was sent while issue was closed. 
Change committed as 265126

Powered by Google App Engine
This is Rietveld 408576698